fix(cli): spread commonFlags on billing cancel (RND-567)#160
Open
mpjunior92 wants to merge 1 commit into
Open
Conversation
The `billing cancel` command was cherry-picking only `private-key` and `verbose` from commonFlags, leaving `--environment`, `--rpc-url`, `--max-fee-per-gas`, `--max-priority-fee`, and `--nonce` undeclared. This made the command unusable in CI/scripted flows because there was no non-interactive way to pick the environment. Spread `...commonFlags` like the other billing subcommands (status, subscribe, top-up, list-cards) so all common flags are accepted; keep `product` and `force` flags on top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ecloud billing cancelcherry-picked onlyprivate-keyandverbosefromcommonFlags, leaving--environment(and--rpc-url,--max-fee-per-gas,--max-priority-fee,--nonce) undeclared. That made the command unusable in CI / scripted flows:--environment sepolia-deverrored withNonexistent flag: --environment, andECLOUD_ENV=sepolia-devwas ignored because the env binding lives oncommonFlags.environment.This change spreads
...commonFlagslike every other billing subcommand (status,subscribe,top-up,list-cards), keepingproductandforceflags on top.Resolves RND-567.
Test plan
pnpm --filter @layr-labs/ecloud-cli run build:devpassespnpm --filter @layr-labs/ecloud-cli run typecheckclean forcancel.ts(only pre-existing unrelated test-globals errors)eslint src/commands/billing/cancel.tscleanecloud billing cancel --helpnow lists--environment,--rpc-url,--max-fee-per-gas,--max-priority-fee,--nonceecloud billing cancel --environment sepolia-dev --force --private-key …reaches the cancellation flow (no "Nonexistent flag" / "Cannot prompt")