Prefer Ladybug root over nested dataset dir

Author: adsharma

test/lbug_test_paths.py

@@ -7,10 +7,10 @@
 def _resolve_lbug_root(anchor: Path | None = None) -> Path:
     repo_root = (anchor or _REPO_ROOT).resolve()
     for candidate in (repo_root, *repo_root.parents):
-        if (candidate / "dataset").is_dir():
-            return candidate
         if candidate.name == "python_api" and candidate.parent.name == "tools":
             return candidate.parent.parent
+        if (candidate / "dataset").is_dir():
+            return candidate
         if (candidate / "ladybug" / "dataset").is_dir():
             return candidate / "ladybug"
     return repo_root

test/test_test_helper.py

@@ -24,3 +24,13 @@ def test_nested_ci_checkout_dataset_path_is_outside_python_api_tree() -> None:
     assert dataset_root.as_posix().endswith(
         "/ladybug-python/ladybug-python/ladybug/dataset"
     )
+
+
+def test_nested_ci_checkout_prefers_parent_ladybug_root_over_local_dataset_dir() -> None:
+    repo_root = Path(
+        "/home/runner/work/ladybug-python/ladybug-python/ladybug/tools/python_api"
+    )
+
+    resolved = _resolve_lbug_root(repo_root)
+    assert resolved.name == "ladybug"
+    assert "/tools/python_api" not in resolved.as_posix()