diff --git a/api/src/org/labkey/api/annotations/JavaRuntimeVersion.java b/api/src/org/labkey/api/annotations/JavaRuntimeVersion.java index a2e7057cda8..2681523df25 100644 --- a/api/src/org/labkey/api/annotations/JavaRuntimeVersion.java +++ b/api/src/org/labkey/api/annotations/JavaRuntimeVersion.java @@ -19,8 +19,6 @@ Used to mark code that is specific to a particular Java runtime version, for example, hacks that work around problems in the runtime or links to the Java documentation. Re-evaluate these when Java versions are released or deprecated. Search for text "@JavaRuntimeVersion" to find all usages. - User: adam - Date: 9/11/13 */ import java.lang.annotation.Retention; diff --git a/api/src/org/labkey/api/files/FileSystemWatcherImpl.java b/api/src/org/labkey/api/files/FileSystemWatcherImpl.java index 5f8339d4352..3d1781b7ac1 100644 --- a/api/src/org/labkey/api/files/FileSystemWatcherImpl.java +++ b/api/src/org/labkey/api/files/FileSystemWatcherImpl.java @@ -23,6 +23,7 @@ import org.jetbrains.annotations.Nullable; import org.junit.Assert; import org.junit.Test; +import org.labkey.api.annotations.JavaRuntimeVersion; import org.labkey.api.cloud.CloudWatchService; import org.labkey.api.cloud.CloudWatcherConfig; import org.labkey.api.collections.ConcurrentHashSet; @@ -61,16 +62,20 @@ import static java.nio.file.StandardWatchEventKinds.OVERFLOW; /** - * Wraps the low-level Java WatchService API with a simple listener-based interface. Unlike WatchService, which is limited to one - * registration per file system directory, a single instance of this class should be sufficient to handle all file system listener - * needs of the entire server. - * - * Callers register a FileSystemDirectoryListener on a directory Path, specifying the desired WatchEvent.Kinds (CREATE, DELETE, - * and/or MODIFY); whenever an event occurs on any file or child directory in that directory, the appropriate method is invoked - * on all listeners registered on that directory that have requested notification of that event. - * - * This class is thread-safe, for both listener registration and event invocation. Implementations of FileSystemDirectoryListener - * must be thread-safe. Listener methods must return quickly since they are all invoked by a single thread. + *
Wraps the low-level Java WatchService API with a simple listener-based interface. Unlike WatchService, which is + * limited to one registration per file system directory, a single instance of this class should be sufficient to handle + * all file system listener needs of the entire server. + *
+ *+ * Callers register a FileSystemDirectoryListener on a directory Path, specifying the desired WatchEvent.Kinds (CREATE, + * DELETE, and/or MODIFY); whenever an event occurs on any file or child directory in that directory, the appropriate + * method is invoked on all listeners registered on that directory that have requested notification of that event. + *
+ *+ * This class is thread-safe, for both listener registration and event invocation. Implementations of + * FileSystemDirectoryListener must be thread-safe. Listener methods must return quickly since they are all invoked by a + * single thread. + *
*/ public class FileSystemWatcherImpl implements FileSystemWatcher { @@ -586,8 +591,10 @@ public void overflow() assertEquals(3, created.size()); assertTrue(created.containsAll(Set.of("a", "b", "c"))); - // Note: Modified events occur on delete on Windows, but not Linux - Set