From 1dc4200edb61cb29fe632bf60cab5b3b51618e97 Mon Sep 17 00:00:00 2001 From: Marty Pradere Date: Thu, 24 Jul 2025 09:08:56 -0700 Subject: [PATCH 1/6] Update to use EHR folder --- .../AbstractGenericONPRC_EHRTest.java | 48 +++++++++---------- .../test/tests/onprc_ehr/ONPRC_EHRTest.java | 38 ++++++++------- .../test/tests/onprc_ehr/ONPRC_EHRTest2.java | 10 ++-- 3 files changed, 48 insertions(+), 48 deletions(-) diff --git a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java index ad5fd9b60..6556e3af8 100644 --- a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java +++ b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java @@ -83,12 +83,6 @@ public List getAssociatedModules() return Arrays.asList("ehr", "onprc_ehr"); } - @Override - public String getContainerPath() - { - return getProjectName(); - } - @Override protected EHRClientAPIHelper getApiHelper() { @@ -103,6 +97,10 @@ protected void setEHRModuleProperties(ModulePropertyValue... extraProps) super._containerHelper.enableModule("ONPRC_Billing"); super._containerHelper.enableModule("ONPRC_BillingPublic"); super._containerHelper.enableModule("SLA"); + goToEHRFolder(); + super._containerHelper.enableModule("ONPRC_Billing"); + super._containerHelper.enableModule("ONPRC_BillingPublic"); + super._containerHelper.enableModule("SLA"); super.setEHRModuleProperties( new ModulePropertyValue("ONPRC_Billing", "/" + getProjectName(), "BillingContainer", "/" + getContainerPath()), new ModulePropertyValue("ONPRC_Billing", "/" + getProjectName(), "BillingContainer_Public", "/" + getContainerPath()), @@ -134,7 +132,7 @@ protected void createBirthRecords() throws Exception log("creating birth records"); //note: these should cascade insert into demographics - EHRClientAPIHelper apiHelper = new EHRClientAPIHelper(this, getProjectName()); + EHRClientAPIHelper apiHelper = new EHRClientAPIHelper(this, getContainerPath()); String schema = "study"; String query = "birth"; String parentageQuery = "parentage"; @@ -185,12 +183,12 @@ protected void createBirthRecords() throws Exception protected void doExtraPreStudyImportSetup() throws IOException, CommandException { //create onprc_billing_public linked schema - beginAt(getProjectName()); + goToEHRFolder(); SchemaHelper schemaHelper = new SchemaHelper(this); - schemaHelper.createLinkedSchema(this.getProjectName(), "onprc_billing_public", "/" + this.getContainerPath(), "onprc_billing_public", null, null, null); + schemaHelper.createLinkedSchema(getContainerPath(), "onprc_billing_public", "/" + getContainerPath(), "onprc_billing_public", null, null, null); //create Labfee_NoChargeProjects - beginAt(getProjectName()); + goToEHRFolder(); ListDefinition listDef = new IntListDefinition("Labfee_NoChargeProjects", "key"); listDef.addField(new FieldDefinition("project", FieldDefinition.ColumnType.Integer)); @@ -198,7 +196,7 @@ protected void doExtraPreStudyImportSetup() throws IOException, CommandException listDef.addField(new FieldDefinition("dateDisabled", FieldDefinition.ColumnType.DateAndTime)); listDef.addField(new FieldDefinition("Createdb", FieldDefinition.ColumnType.Integer)); listDef.addField(new FieldDefinition("Notes", FieldDefinition.ColumnType.String)); - listDef.getCreateCommand().execute(createDefaultConnection(), getProjectName()); + listDef.getCreateCommand().execute(createDefaultConnection(), getContainerPath()); ListDefinition listDef2 = new VarListDefinition("GeneticValue"); listDef2.setKeyName("Id"); @@ -212,12 +210,12 @@ protected void doExtraPreStudyImportSetup() throws IOException, CommandException listDef2.addField(new FieldDefinition("import", FieldDefinition.ColumnType.String)); listDef2.addField(new FieldDefinition("value", FieldDefinition.ColumnType.String)); listDef2.addField(new FieldDefinition("rank", FieldDefinition.ColumnType.Integer)); - listDef2.getCreateCommand().execute(createDefaultConnection(), getProjectName()); + listDef2.getCreateCommand().execute(createDefaultConnection(), getContainerPath()); ListDefinition listDef3 = new IntListDefinition("Special_Aliases", "Key"); listDef3.addField(new FieldDefinition("Category", FieldDefinition.ColumnType.String)); listDef3.addField(new FieldDefinition("Alias", FieldDefinition.ColumnType.String)); - listDef3.getCreateCommand().execute(createDefaultConnection(), getProjectName()); + listDef3.getCreateCommand().execute(createDefaultConnection(), getContainerPath()); ListDefinition listDef4 = new IntListDefinition("Rpt_ChargesProjection", "RowId"); listDef4.addField(new FieldDefinition("ChargeId", FieldDefinition.ColumnType.Integer)); @@ -240,7 +238,7 @@ protected void doExtraPreStudyImportSetup() throws IOException, CommandException listDef4.addField(new FieldDefinition("Aprate8", FieldDefinition.ColumnType.Decimal)); listDef4.addField(new FieldDefinition("Aprate9", FieldDefinition.ColumnType.Decimal)); listDef4.addField(new FieldDefinition("PostedDate", FieldDefinition.ColumnType.DateAndTime)); - listDef4.getCreateCommand().execute(createDefaultConnection(), getProjectName()); + listDef4.getCreateCommand().execute(createDefaultConnection(), getContainerPath()); // Mock up a table in the MHC_Data schema instead of needing to mock up all of its dependencies too ListDefinition listDef5 = new IntListDefinition("MHC_Data_Unified", "RowId"); @@ -255,17 +253,17 @@ protected void doExtraPreStudyImportSetup() throws IOException, CommandException listDef5.addField(new FieldDefinition("datatype", FieldDefinition.ColumnType.String)); listDef5.addField(new FieldDefinition("result", FieldDefinition.ColumnType.String)); listDef5.addField(new FieldDefinition("type", FieldDefinition.ColumnType.String)); - listDef5.getCreateCommand().execute(createDefaultConnection(), getProjectName()); - - schemaHelper.createLinkedSchema(this.getProjectName(), "dbo", "/" + this.getContainerPath(), null, "lists", null, null); - schemaHelper.createLinkedSchema(this.getProjectName(), "MHC_Data", "/" + this.getContainerPath(), null, "lists", null, null); - schemaHelper.createLinkedSchema(this.getProjectName(), "ehrSLA", "/" + this.getContainerPath(), "ehrSLA", "sla", null, null); - schemaHelper.createLinkedSchema(this.getProjectName(), "financepublic", "/" + this.getContainerPath(), "financepublic", "onprc_billing", null, null); - schemaHelper.createLinkedSchema(this.getProjectName(), "publicehr", "/" + this.getContainerPath(), null, "ehr", null, null); - schemaHelper.createLinkedSchema(this.getProjectName(), "onprc_ehrSLA", "/" + this.getContainerPath(), null, "onprc_ehr", null, null); - schemaHelper.createLinkedSchema(this.getProjectName(), "pf_onprcehrPublic", "/" + this.getContainerPath(), "pf_onprcehrPublic", null, null, null); - schemaHelper.createLinkedSchema(this.getProjectName(), "pf_publicEHR", "/" + this.getContainerPath(), "pf_publicEHR", null, null, null); - schemaHelper.createLinkedSchema(this.getProjectName(), "pf_publicFinance", "/" + this.getContainerPath(), "pf_publicFinance", null, null, null); + listDef5.getCreateCommand().execute(createDefaultConnection(), getContainerPath()); + + schemaHelper.createLinkedSchema(getContainerPath(), "dbo", "/" + getContainerPath(), null, "lists", null, null); + schemaHelper.createLinkedSchema(getContainerPath(), "MHC_Data", "/" + getContainerPath(), null, "lists", null, null); + schemaHelper.createLinkedSchema(getContainerPath(), "ehrSLA", "/" + getContainerPath(), "ehrSLA", "sla", null, null); + schemaHelper.createLinkedSchema(getContainerPath(), "financepublic", "/" + getContainerPath(), "financepublic", "onprc_billing", null, null); + schemaHelper.createLinkedSchema(getContainerPath(), "publicehr", "/" + getContainerPath(), null, "ehr", null, null); + schemaHelper.createLinkedSchema(getContainerPath(), "onprc_ehrSLA", "/" + getContainerPath(), null, "onprc_ehr", null, null); + schemaHelper.createLinkedSchema(getContainerPath(), "pf_onprcehrPublic", "/" + getContainerPath(), "pf_onprcehrPublic", null, null, null); + schemaHelper.createLinkedSchema(getContainerPath(), "pf_publicEHR", "/" + getContainerPath(), "pf_publicEHR", null, null, null); + schemaHelper.createLinkedSchema(getContainerPath(), "pf_publicFinance", "/" + getContainerPath(), "pf_publicFinance", null, null, null); } @Override diff --git a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest.java b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest.java index ed3a2597b..85eb70386 100644 --- a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest.java +++ b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest.java @@ -81,7 +81,7 @@ public class ONPRC_EHRTest extends AbstractGenericONPRC_EHRTest { protected String PROJECT_NAME = "ONPRC_EHR_TestProject"; - private final String ANIMAL_HISTORY_URL = "/" + getProjectName() + "/ehr-animalHistory.view"; + private final String ANIMAL_HISTORY_URL = "/" + getContainerPath() + "/ehr-animalHistory.view"; @Override protected String getProjectName() @@ -160,7 +160,7 @@ public void testAssignmentApi() throws Exception { final String investLastName = "Tester"; - goToProjectHome(); + goToEHRFolder(); String[][] CONDITION_FLAGS = new String[][]{ {"Nonrestricted", "201"}, @@ -345,7 +345,7 @@ public void testAssignmentApi() throws Exception @Test public void testAnimalGroupsApi() throws Exception { - goToProjectHome(); + goToEHRFolder(); int group1 = getOrCreateGroup("Group1"); int group2 = getOrCreateGroup("Group2"); @@ -364,7 +364,7 @@ public void testAnimalGroupsApi() throws Exception @Test public void testProjectProtocolApi() throws Exception { - goToProjectHome(); + goToEHRFolder(); //auto-assignment of IDs String protocolTitle = generateGUID(); @@ -399,7 +399,7 @@ public void testProjectProtocolApi() throws Exception @Test public void testDrugApi() { - goToProjectHome(); + goToEHRFolder(); getApiHelper().testValidationMessage(DATA_ADMIN.getEmail(), "study", "drug", new String[]{"Id", "date", "code", "outcome", "remark", "amount", "amount_units", "volume", "vol_units", "QCStateLabel", "objectid", "_recordId"}, new Object[][]{ {MORE_ANIMAL_IDS[0], new Date(), "code", "Abnormal", null, 1.0, "mg", 2.0, "mL", EHRQCState.COMPLETED.label, generateGUID(), "recordID"} @@ -470,7 +470,7 @@ public void testDrugApi() @Test public void testArrivalApi() throws Exception { - goToProjectHome(); + goToEHRFolder(); final String arrivalId1 = "Arrival1"; final String arrivalId2 = "Arrival2"; @@ -578,11 +578,11 @@ public void testCustomActions() throws Exception } //colony overview - goToProjectHome(); + goToEHRFolder(); waitAndClickAndWait(Locator.tagContainingText("a", "Colony Overview")); //NOTE: depending on the test order and whether demographics records were created, so we test this - EHRClientAPIHelper apiHelper = new EHRClientAPIHelper(this, getProjectName()); + EHRClientAPIHelper apiHelper = new EHRClientAPIHelper(this, getContainerPath()); boolean hasDemographics = apiHelper.getRowCount("study", "demographics") > 0; boolean hasCases = apiHelper.getRowCount("study", "cases") > 0; int aggregatePanelCount = 0; @@ -629,7 +629,7 @@ public void testCustomActions() throws Exception //bulk history export log("testing bulk history export"); - goToProjectHome(); + goToEHRFolder(); waitAndClickAndWait(Locator.tagContainingText("a", "Bulk History Export")); waitForElement(Locator.tagContainingText("label", "Enter Animal Id(s)")); Ext4FieldRef.getForLabel(this, "Enter Animal Id(s)").setValue("12345;23432\nABCDE"); @@ -643,7 +643,7 @@ public void testCustomActions() throws Exception assertElementNotPresent(Locator.tagContainingText("label", "Projects").notHidden()); //check redaction //compare lists of animals - goToProjectHome(); + goToEHRFolder(); waitAndClickAndWait(Locator.tagContainingText("a", "Compare Lists of Animals")); waitForElement(Locator.id("unique")); setFormElement(Locator.id("unique"), "1,2,1\n3,3;4"); @@ -673,7 +673,7 @@ public void testCustomActions() throws Exception ensureGroupMember(groupId, MORE_ANIMAL_IDS[0]); ensureGroupMember(groupId, MORE_ANIMAL_IDS[1]); - goToProjectHome(); + goToEHRFolder(); waitAndClickAndWait(Locator.tagContainingText("a", "Animal Groups")); waitForElement(Locator.tagContainingText("span", "Active Groups")); DataRegionTable dr = new DataRegionTable("query", this); @@ -682,7 +682,7 @@ public void testCustomActions() throws Exception Assert.assertEquals(2, membersTable.getDataRowCount()); //more reports - goToProjectHome(); + goToEHRFolder(); waitAndClickAndWait(Locator.tagContainingText("a", "More Reports")); waitForElement(Locator.tagContainingText("a", "View Summary of Clinical Tasks")); } @@ -691,7 +691,7 @@ public void testCustomActions() throws Exception public void testPrintableReports() { // NOTE: these primarily run SSRS, so we will just set up the UI and test whether the URL matches expectations - goToProjectHome(); + goToEHRFolder(); waitAndClickAndWait(Locator.tagContainingText("a", "Printable Reports")); waitForElement(Ext4Helper.Locators.ext4Button("Print Version")); @@ -716,7 +716,7 @@ public void testPrintableReports() closeExtraWindows(); // Now try the CITES Report - goToProjectHome(); + goToEHRFolder(); waitAndClickAndWait(Locator.tagContainingText("a", "More Reports")); waitAndClickAndWait(Locator.tagContainingText("a", "Cites Report")); waitForElement(Locator.textarea("animalField")); @@ -748,7 +748,7 @@ private void validateSsrsUrlParams(String reportName, String... additionalParams @Test public void testPedigreeReport() { - goToProjectHome(); + goToEHRFolder(); beginAtAnimalHistoryTab(); String id = ID_PREFIX + 10; @@ -1246,7 +1246,7 @@ public void testWeightEntry() @Test public void testGeneticsPipeline() { - goToProjectHome(); + goToEHRFolder(); //retain pipeline log for debugging getArtifactCollector().addArtifactLocation(new File(TestFileUtils.getLabKeyRoot(), getModulePath() + GENETICS_PIPELINE_LOG_PATH), @@ -1269,7 +1269,7 @@ public void testGeneticsPipeline() Test coverage for : https://www.labkey.org/ONPRC/Support%20Tickets/issues-details.view?issueId=41231 */ - goToProjectHome(); + goToEHRFolder(); beginAtAnimalHistoryTab(); AnimalHistoryPage animalHistoryPage = new AnimalHistoryPage<>(getDriver()); animalHistoryPage.searchSingleAnimal("99995,99996,99997,99998,99999,999910"); @@ -1315,7 +1315,7 @@ public void testNotifications() { setupNotificationService(); - goToProjectHome(); + goToEHRFolder(); waitAndClickAndWait(Locators.bodyPanel().append(Locator.tagContainingText("a", "EHR Admin Page"))); waitAndClickAndWait(Locator.tagContainingText("a", "Notification Admin")); @@ -1758,6 +1758,8 @@ private void setDrugAmountField(String fieldName, int rowIdx, Object value, Map< @Test public void testBehaviorRounds() throws Exception { + goToEHRFolder(); + _helper.goToTaskForm("BSU Rounds"); //create a previous observation for the active case diff --git a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java index a2c7847ae..7bf84bb46 100644 --- a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java +++ b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java @@ -125,7 +125,7 @@ protected boolean doSetUserPasswords() @Test public void testBirthStatusApi() throws Exception { - goToProjectHome(); + goToEHRFolder(); //first create record for dam, along w/ animal group and SPF status. we expect this to automatically create a demographics record w/ the right status final String damId1 = "Dam1"; @@ -724,7 +724,7 @@ public void testBirthInheritFromDam() throws Exception Date damBirth = prepareDate(DateUtils.truncate(new Date(), Calendar.DATE), -720, 0); // Navigate to the start of the project - goToProjectHome(); + goToEHRFolder(); // Insert dam into birth via API log("Creating Dam"); @@ -860,7 +860,7 @@ public void testManageTreatment() throws Exception }); getApiHelper().doSaveRows(PasswordUtil.getUsername(), insertCommand, getExtraContext()); - goToProjectHome(); + goToEHRFolder(); waitAndClickAndWait(Locator.linkWithText("Animal History")); String query = "textfield[itemId=subjArea]"; @@ -1267,7 +1267,7 @@ public void testTreatmentToDrugETL() throws IOException, CommandException String animalId = "12345"; log("Creating the Treatment order request"); - goToProjectHome(); + goToEHRFolder(); clickAndWait(Locator.linkWithText("Enter Data / Task Review")); waitAndClickAndWait(Locator.linkWithText("Medications/Diet")); @@ -1302,7 +1302,7 @@ public void bloodRequestTest() throws IOException, CommandException LocalDateTime now = LocalDateTime.now(); String animalId = "12345"; - goToProjectHome(); + goToEHRFolder(); log("Inserting the charge unit necessary for blood draw request"); InsertRowsCommand chargeUnitCommand = new InsertRowsCommand("onprc_billing", "chargeUnits"); From e5664e715cdf4019298512ac152c9f5538b8c3d6 Mon Sep 17 00:00:00 2001 From: Marty Pradere Date: Sat, 26 Jul 2025 22:41:52 -0700 Subject: [PATCH 2/6] fix etl test --- .../src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java index 7bf84bb46..f460fb88a 100644 --- a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java +++ b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java @@ -82,7 +82,7 @@ public class ONPRC_EHRTest2 extends AbstractONPRC_EHRTest private final String PROJECT_NAME = "ONPRC_EHR_TestProject2"; private final String ANIMAL_HISTORY_URL = "/ehr/" + getProjectName() + "/animalHistory.view?"; public AbstractContainerHelper _containerHelper = new APIContainerHelper(this); - public DataIntegrationHelper _etlHelper = new DataIntegrationHelper(PROJECT_NAME); + public DataIntegrationHelper _etlHelper = new DataIntegrationHelper(getContainerPath()); protected DateTimeFormatter _dateTimeFormatter = DateTimeFormatter.ofPattern("yyyy-MM-dd"); @BeforeClass From a3aebade511d772f625697e532ad4bd09ca48726 Mon Sep 17 00:00:00 2001 From: Marty Pradere Date: Wed, 30 Jul 2025 09:59:12 -0700 Subject: [PATCH 3/6] Duplicate testing --- .../src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java index f460fb88a..d013b068a 100644 --- a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java +++ b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java @@ -122,6 +122,12 @@ protected boolean doSetUserPasswords() return true; } + @Override + public void testCrawlEhrLinks() + { + // This is being done in ONPRC_EHRTest, don't need to do it here as well. + } + @Test public void testBirthStatusApi() throws Exception { From 9a605f6dff4cc207a8319ca03775aa04ba5b6e99 Mon Sep 17 00:00:00 2001 From: Marty Pradere Date: Wed, 30 Jul 2025 21:00:18 -0700 Subject: [PATCH 4/6] skip crawling --- .../org/labkey/test/tests/onprc_ehr/ONPRC_BillingTest.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_BillingTest.java b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_BillingTest.java index 0dcf9068e..12c91d5a5 100644 --- a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_BillingTest.java +++ b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_BillingTest.java @@ -101,6 +101,12 @@ private void doSetUp() throws Exception _portalHelper.moveWebPart("Finance", PortalHelper.Direction.UP); } + @Override + public void testCrawlEhrLinks() + { + // This is being done in ONPRC_EHRTest, don't need to do it here as well. + } + @Test public void testNotifications() { From f91febb5cf6f632911a0fb03be449b7f81435f3a Mon Sep 17 00:00:00 2001 From: Marty Pradere Date: Wed, 30 Jul 2025 21:02:36 -0700 Subject: [PATCH 5/6] Move override --- .../test/tests/onprc_ehr/AbstractONPRC_EHRTest.java | 6 ++++++ .../labkey/test/tests/onprc_ehr/ONPRC_BillingTest.java | 8 +------- .../org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java | 6 ------ 3 files changed, 7 insertions(+), 13 deletions(-) diff --git a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractONPRC_EHRTest.java b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractONPRC_EHRTest.java index 25e1d8dab..80a0f3b94 100644 --- a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractONPRC_EHRTest.java +++ b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractONPRC_EHRTest.java @@ -55,4 +55,10 @@ public void testCustomButtons(){} @Override public void customActionsTest(){} + + @Override + public void testCrawlEhrLinks() + { + // This is being done in ONPRC_EHRTest, don't need to do it here as well. + } } diff --git a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_BillingTest.java b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_BillingTest.java index 12c91d5a5..2d2c2eecc 100644 --- a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_BillingTest.java +++ b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_BillingTest.java @@ -100,13 +100,7 @@ private void doSetUp() throws Exception _portalHelper.addWebPart("ONPRC Finance"); _portalHelper.moveWebPart("Finance", PortalHelper.Direction.UP); } - - @Override - public void testCrawlEhrLinks() - { - // This is being done in ONPRC_EHRTest, don't need to do it here as well. - } - + @Test public void testNotifications() { diff --git a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java index d013b068a..f460fb88a 100644 --- a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java +++ b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java @@ -122,12 +122,6 @@ protected boolean doSetUserPasswords() return true; } - @Override - public void testCrawlEhrLinks() - { - // This is being done in ONPRC_EHRTest, don't need to do it here as well. - } - @Test public void testBirthStatusApi() throws Exception { From 580bc2a1792e2c52530fc035ea36796773e2379d Mon Sep 17 00:00:00 2001 From: Marty Pradere Date: Fri, 1 Aug 2025 06:01:51 -0700 Subject: [PATCH 6/6] Update onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java Co-authored-by: Trey Chadick --- .../test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java index 6556e3af8..55daedca3 100644 --- a/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java +++ b/onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java @@ -98,9 +98,7 @@ protected void setEHRModuleProperties(ModulePropertyValue... extraProps) super._containerHelper.enableModule("ONPRC_BillingPublic"); super._containerHelper.enableModule("SLA"); goToEHRFolder(); - super._containerHelper.enableModule("ONPRC_Billing"); - super._containerHelper.enableModule("ONPRC_BillingPublic"); - super._containerHelper.enableModule("SLA"); + super._containerHelper.enableModules(List.of("ONPRC_Billing", "ONPRC_BillingPublic", "SLA")); super.setEHRModuleProperties( new ModulePropertyValue("ONPRC_Billing", "/" + getProjectName(), "BillingContainer", "/" + getContainerPath()), new ModulePropertyValue("ONPRC_Billing", "/" + getProjectName(), "BillingContainer_Public", "/" + getContainerPath()),