Skip to content

Commit bc68085

Browse files
committed
package updates, BEM css names and more cleanup
1 parent 1be297e commit bc68085

11 files changed

Lines changed: 152 additions & 158 deletions

File tree

ehr/package-lock.json

Lines changed: 47 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ehr/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
"lint-fix": "eslint --fix"
1616
},
1717
"dependencies": {
18-
"@labkey/api": "1.44.0",
19-
"@labkey/components": "6.72.1",
18+
"@labkey/api": "1.45.0",
19+
"@labkey/components": "7.13.1",
2020
"@labkey/ehr": "0.0.4-fb-ehr-hist-id-search.12"
2121
},
2222
"devDependencies": {

labkey-ui-ehr/package-lock.json

Lines changed: 15 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

labkey-ui-ehr/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
},
5555
"homepage": "https://github.com/LabKey/ehrModules/labkey-ui-ehr#readme",
5656
"dependencies": {
57-
"@labkey/components": "6.72.1"
57+
"@labkey/components": "7.13.1"
5858
},
5959
"devDependencies": {
6060
"@labkey/build": "8.7.0",

labkey-ui-ehr/src/ParticipantHistory/SearchByIdPanel/IdResolutionFeedback.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ describe('IdResolutionFeedback', () => {
181181

182182
const { container } = render(<IdResolutionFeedback resolutionResult={resolutionResult} />);
183183

184-
const resolvedItems = container.querySelectorAll('.resolved-item');
184+
const resolvedItems = container.querySelectorAll('.id-resolution-feedback__item--resolved');
185185
expect(resolvedItems).toHaveLength(2);
186186
});
187187

@@ -193,7 +193,7 @@ describe('IdResolutionFeedback', () => {
193193

194194
const { container } = render(<IdResolutionFeedback resolutionResult={resolutionResult} />);
195195

196-
const notFoundItems = container.querySelectorAll('.not-found-item');
196+
const notFoundItems = container.querySelectorAll('.id-resolution-feedback__item--not-found');
197197
expect(notFoundItems).toHaveLength(2);
198198
});
199199
});

labkey-ui-ehr/src/ParticipantHistory/SearchByIdPanel/IdResolutionFeedback.tsx

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -27,35 +27,39 @@ export const IdResolutionFeedback: FC<IdResolutionFeedbackProps> = ({ resolution
2727

2828
return (
2929
<div className="id-resolution-feedback">
30-
<h3 className="title">ID Resolution</h3>
30+
<h3 className="id-resolution-feedback__title">ID Resolution</h3>
3131

3232
{resolved.length > 0 && (
33-
<div className="section">
34-
<h4 className="section-title resolved">Resolved ({resolved.length})</h4>
35-
<div className="items">
33+
<div className="id-resolution-feedback__section">
34+
<h4 className="id-resolution-feedback__section-title id-resolution-feedback__section-title--resolved">
35+
Resolved ({resolved.length})
36+
</h4>
37+
<div className="id-resolution-feedback__items">
3638
{directMatches.map(match => (
37-
<div className="item resolved-item" key={match.inputId}>
38-
<span className="resolved-id">{match.resolvedId}</span>
39+
<div className="id-resolution-feedback__item id-resolution-feedback__item--resolved" key={match.inputId}>
40+
<span className="id-resolution-feedback__resolved-id">{match.resolvedId}</span>
3941
</div>
4042
))}
4143
{aliasMatches.map(match => (
42-
<div className="item resolved-item" key={match.inputId}>
43-
<span className="input-id">{match.inputId}</span>
44-
<span className="arrow"></span>
45-
<span className="resolved-id">{match.resolvedId}</span>
46-
{match.aliasType && <span className="alias-type">({match.aliasType})</span>}
44+
<div className="id-resolution-feedback__item id-resolution-feedback__item--resolved" key={match.inputId}>
45+
<span className="id-resolution-feedback__input-id">{match.inputId}</span>
46+
<span className="id-resolution-feedback__arrow"></span>
47+
<span className="id-resolution-feedback__resolved-id">{match.resolvedId}</span>
48+
{match.aliasType && <span className="id-resolution-feedback__alias-type">({match.aliasType})</span>}
4749
</div>
4850
))}
4951
</div>
5052
</div>
5153
)}
5254

5355
{notFound.length > 0 && (
54-
<div className="section">
55-
<h4 className="section-title not-found">Not Found ({notFound.length})</h4>
56-
<div className="items">
56+
<div className="id-resolution-feedback__section">
57+
<h4 className="id-resolution-feedback__section-title id-resolution-feedback__section-title--not-found">
58+
Not Found ({notFound.length})
59+
</h4>
60+
<div className="id-resolution-feedback__items">
5761
{notFound.map(id => (
58-
<div className="item not-found-item" key={id}>
62+
<div className="id-resolution-feedback__item id-resolution-feedback__item--not-found" key={id}>
5963
{id}
6064
</div>
6165
))}

0 commit comments

Comments
 (0)