diff --git a/SkylineToolsStore/src/org/labkey/skylinetoolsstore/SkylineToolsStoreController.java b/SkylineToolsStore/src/org/labkey/skylinetoolsstore/SkylineToolsStoreController.java index 147a7205..edcdb7de 100644 --- a/SkylineToolsStore/src/org/labkey/skylinetoolsstore/SkylineToolsStoreController.java +++ b/SkylineToolsStore/src/org/labkey/skylinetoolsstore/SkylineToolsStoreController.java @@ -594,7 +594,7 @@ else if (!getContainer().hasPermission(getUser(), InsertPermission.class)) tool.setLatest(true); SkylineToolsStoreManager.get().insertTool(c, getUser(), tool); - return HttpView.redirect(SkylineToolStoreUrls.getToolDetailsUrl(tool).getLocalURIString()); + return HttpView.redirect(SkylineToolStoreUrls.getToolDetailsUrl(tool)); } } else @@ -868,7 +868,6 @@ public DeleteSupplementAction() @Override public ModelAndView handleRequestInternal(HttpServletRequest httpServletRequest, HttpServletResponse httpServletResponse) throws Exception { - final String sender = httpServletRequest.getParameter("sender"); final int suppTarget = Integer.parseInt(httpServletRequest.getParameter("supptarget")); final String suppFile = httpServletRequest.getParameter("suppFile"); @@ -890,8 +889,7 @@ public ModelAndView handleRequestInternal(HttpServletRequest httpServletRequest, else throw new Exception(); - return HttpView.redirect((sender != null) ? sender : - SkylineToolStoreUrls.getToolDetailsUrl(tool).getLocalURIString()); + return HttpView.redirect(SkylineToolStoreUrls.getToolDetailsUrl(tool)); } @Override @@ -1049,8 +1047,8 @@ public ModelAndView handleRequestInternal(HttpServletRequest httpServletRequest, } } - return HttpView.redirect((senderUrl != null) ? senderUrl.getLocalURIString() : - SkylineToolStoreUrls.getToolStoreHomeUrl(toolStoreContainer, getUser()).getLocalURIString()); + return HttpView.redirect((senderUrl != null) ? senderUrl : + SkylineToolStoreUrls.getToolStoreHomeUrl(toolStoreContainer, getUser())); } @Override @@ -1383,8 +1381,9 @@ public ModelAndView handleRequestInternal(HttpServletRequest httpServletRequest, Container toolStoreContainer = tool != null ? tool.getContainerParent() : getContainer(); - return HttpView.redirect((sender != null) ? sender : - SkylineToolStoreUrls.getToolStoreHomeUrl(toolStoreContainer, getUser()).getLocalURIString()); + + return HttpView.redirect((sender != null) ? new ActionURL(sender) : + SkylineToolStoreUrls.getToolStoreHomeUrl(toolStoreContainer, getUser())); } else { @@ -1505,8 +1504,7 @@ else if (!lowerName.startsWith("tool-inf/") || else tool.writeIconToFile(makeFile(tool.lookupContainer(), "icon.png"), "png"); - String sender = httpServletRequest.getParameter("sender"); - return HttpView.redirect((sender != null) ? sender : new ActionURL(BeginAction.class, getContainer()).getLocalURIString()); + return HttpView.redirect(SkylineToolStoreUrls.getToolDetailsUrl(tool)); } @Override diff --git a/SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolDetails.jsp b/SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolDetails.jsp index 941c572c..26a97fce 100644 --- a/SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolDetails.jsp +++ b/SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolDetails.jsp @@ -740,7 +740,7 @@ a { text-decoration: none; } buttons: { Ok: function() { setButtonsEnabled(false); - window.location = "<%=h(urlFor(SkylineToolsStoreController.DeleteLatestAction.class).addParameter("id", tool.getRowId()).addParameter("sender", toolDetailsLatestUrl.getLocalURIString()))%>" + window.location = <%=q(urlFor(SkylineToolsStoreController.DeleteLatestAction.class).addParameter("id", tool.getRowId()).addParameter("sender", toolDetailsLatestUrl.getLocalURIString()))%> }, Cancel: function() {$(this).dialog("close");} } diff --git a/SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolsStoreWebPart.jsp b/SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolsStoreWebPart.jsp index b780aea8..6fea558f 100644 --- a/SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolsStoreWebPart.jsp +++ b/SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolsStoreWebPart.jsp @@ -187,7 +187,7 @@
-
+