From 779f3429efa3f47cf7fab5ec601e64f7b815b738 Mon Sep 17 00:00:00 2001 From: Matthew Bellew Date: Wed, 9 Apr 2025 16:13:54 -0700 Subject: [PATCH 1/2] rename get*Name() -> get*Identifier() --- mcc/src/org/labkey/mcc/query/MccRequestCustomizer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mcc/src/org/labkey/mcc/query/MccRequestCustomizer.java b/mcc/src/org/labkey/mcc/query/MccRequestCustomizer.java index cf0f8607..a0f9c888 100644 --- a/mcc/src/org/labkey/mcc/query/MccRequestCustomizer.java +++ b/mcc/src/org/labkey/mcc/query/MccRequestCustomizer.java @@ -84,7 +84,7 @@ public boolean isSortable() TableInfo dti = StorageProvisioner.createTableInfo(d.getDomain()); SQLFragment sql = new SQLFragment("(SELECT "). - append(ti.getSqlDialect().getGroupConcat(new SQLFragment("d." + dti.getColumn("participantid").getSelectName()), true, true, new SQLFragment("', '"))). + append(ti.getSqlDialect().getGroupConcat(new SQLFragment("d." + dti.getColumn("participantid").getSelectIdentifier()), true, true, new SQLFragment("', '"))). append(" as expr FROM "). append(" mcc." + MccSchema.TABLE_ANIMAL_REQUESTS + " ar JOIN studydataset.").append(dti.getName()). append(" d ON (d.mccRequestId = ar.rowId)"). From 8f70ca77b99e91b1c9b6b507407995c6d7116153 Mon Sep 17 00:00:00 2001 From: Matthew Bellew Date: Mon, 28 Apr 2025 12:06:49 -0700 Subject: [PATCH 2/2] getGroupConcat() --- mcc/src/org/labkey/mcc/query/MccRequestCustomizer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mcc/src/org/labkey/mcc/query/MccRequestCustomizer.java b/mcc/src/org/labkey/mcc/query/MccRequestCustomizer.java index a0f9c888..74fc427e 100644 --- a/mcc/src/org/labkey/mcc/query/MccRequestCustomizer.java +++ b/mcc/src/org/labkey/mcc/query/MccRequestCustomizer.java @@ -84,7 +84,7 @@ public boolean isSortable() TableInfo dti = StorageProvisioner.createTableInfo(d.getDomain()); SQLFragment sql = new SQLFragment("(SELECT "). - append(ti.getSqlDialect().getGroupConcat(new SQLFragment("d." + dti.getColumn("participantid").getSelectIdentifier()), true, true, new SQLFragment("', '"))). + append(ti.getSqlDialect().getGroupConcat(new SQLFragment("d.").appendIdentifier(dti.getColumn("participantid").getSelectIdentifier()), true, true, new SQLFragment("', '"))). append(" as expr FROM "). append(" mcc." + MccSchema.TABLE_ANIMAL_REQUESTS + " ar JOIN studydataset.").append(dti.getName()). append(" d ON (d.mccRequestId = ar.rowId)").