Skip to content

Remove unused conf/users.yaml and update "Adding users" docs to reflect Thunder-based flow #338

@Aravinda-HWK

Description

@Aravinda-HWK

Summary

conf/users.yaml is a leftover config template that is no longer read by any script in this repository. The README still instructs users to edit it and run bash scripts/user/add_user.sh, but that script no longer exists, so anyone following the README hits a dead end. Users are now added through Thunder's API/UI instead.

Why it's safe to remove

A full search of the repo confirms users.yaml has no live consumers:

  • No shell script, Python script, or Go code reads it.
  • No docker-compose.yaml mounts it as a volume.
  • The only references are the file itself and a single stale mention in README.md (line 114).
  • The companion script scripts/user/add_user.sh was already removed in an earlier cleanup.

The actual user-provisioning flow uses Thunder's /users API endpoint (see scripts/user/create_test_users.sh for an example). Domain configuration comes from conf/silver.yaml.

Tasks

  • Delete conf/users.yaml.
  • Update the "Adding users" section in README.md (around lines 112–120) to remove the reference to users.yaml and add_user.sh, and replace it with instructions for adding users via Thunder (either through the Thunder console UI at https://<host>:8090, or by calling the Thunder /users API).
  • Verify no other docs/scripts reference users.yaml by running grep -rn "users.yaml" . after the change.

Acceptance criteria

  • conf/users.yaml no longer exists in the repo.
  • grep -rn "users.yaml" . returns no results.
  • The "Adding users" section in the README describes the real, working flow and does not reference any non-existent script.

Good first issue notes

This is a documentation + cleanup task — no application code changes are needed. A great way to learn the project's user-provisioning model. If you're new, take a quick look at scripts/user/create_test_users.sh to see how Thunder is called.

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationgood first issueGood for newcomers

Type

No fields configured for Task.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions