From 5b7bbc34dbbeafd683841b221539ace1978c45f6 Mon Sep 17 00:00:00 2001
From: AGibson <4319494+annajgibson@users.noreply.github.com>
Date: Mon, 1 Dec 2025 14:05:15 +0000
Subject: [PATCH 1/3] Update test values

---
 ...migration_properties_data_load_gx_suite.py | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py b/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py
index 63ea4fd1f..f97bd794b 100644
--- a/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py
+++ b/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py
@@ -17,6 +17,28 @@ class PropertiesExpectPropRefColumnValuesToNotBeNull(gxe.ExpectColumnValuesToNot
     description: str = "Expect lpro_propref (prop ref) values to not be Null"
 
 
+class PropertiesExpectPropTypeCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet):
+    column: str = "LPRO_HOU_PTV_CODE"
+    value_set: list = [
+        "BUN",
+        "CMC",
+        "CMF",
+        "COM",
+        "CYC",
+        "DUP",
+        "FLT",
+        "GAR",
+        "HOU",
+        "MAI",
+        "PRA",
+        "PSP",
+        "ROM",
+        "STD",
+        "TRV",
+    ]
+    description: str = "Expect property type codes to contain one of the set"
+
+
 class PropertiesExpectOccStatusCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet):
     column: str = "lpro_sco_code"
     value_set: list = ["OCC", "VOI", "CLO"]
@@ -149,6 +171,7 @@ class PropertiesExpectPropColumnsToMatchOrderedList(
 suite = gx.ExpectationSuite(name="properties_data_load_suite")
 
 suite.add_expectation(PropertiesExpectPropRefColumnValuesToBeUnique())
+suite.add_expectation(PropertiesExpectPropTypeCodeToBeInSet())
 suite.add_expectation(PropertiesExpectOccStatusCodeToBeInSet())
 suite.add_expectation(PropertiesExpectOrgIndicatorToBeInSet())
 suite.add_expectation(PropertiesExpectOwnTypeToBeInSet())

From d9da7225bb3bee16fd7e528e7cac52913c8401ea Mon Sep 17 00:00:00 2001
From: AGibson <4319494+annajgibson@users.noreply.github.com>
Date: Mon, 1 Dec 2025 14:28:34 +0000
Subject: [PATCH 2/3] Update test values; pause housing GX job

---
 ...migration_properties_data_load_gx_suite.py | 23 -------------------
 1 file changed, 23 deletions(-)

diff --git a/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py b/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py
index f97bd794b..63ea4fd1f 100644
--- a/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py
+++ b/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py
@@ -17,28 +17,6 @@ class PropertiesExpectPropRefColumnValuesToNotBeNull(gxe.ExpectColumnValuesToNot
     description: str = "Expect lpro_propref (prop ref) values to not be Null"
 
 
-class PropertiesExpectPropTypeCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet):
-    column: str = "LPRO_HOU_PTV_CODE"
-    value_set: list = [
-        "BUN",
-        "CMC",
-        "CMF",
-        "COM",
-        "CYC",
-        "DUP",
-        "FLT",
-        "GAR",
-        "HOU",
-        "MAI",
-        "PRA",
-        "PSP",
-        "ROM",
-        "STD",
-        "TRV",
-    ]
-    description: str = "Expect property type codes to contain one of the set"
-
-
 class PropertiesExpectOccStatusCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet):
     column: str = "lpro_sco_code"
     value_set: list = ["OCC", "VOI", "CLO"]
@@ -171,7 +149,6 @@ class PropertiesExpectPropColumnsToMatchOrderedList(
 suite = gx.ExpectationSuite(name="properties_data_load_suite")
 
 suite.add_expectation(PropertiesExpectPropRefColumnValuesToBeUnique())
-suite.add_expectation(PropertiesExpectPropTypeCodeToBeInSet())
 suite.add_expectation(PropertiesExpectOccStatusCodeToBeInSet())
 suite.add_expectation(PropertiesExpectOrgIndicatorToBeInSet())
 suite.add_expectation(PropertiesExpectOwnTypeToBeInSet())

From 1892bddccacc4e52cc5fd7eb91f6edccbef41c90 Mon Sep 17 00:00:00 2001
From: AGibson <4319494+annajgibson@users.noreply.github.com>
Date: Tue, 6 Jan 2026 17:02:01 +0000
Subject: [PATCH 3/3] add data type for field value

---
 .../housing_nec_migration_people_data_load_gx_suite.py   | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py b/scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py
index 431ff14a1..30d87f24a 100644
--- a/scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py
+++ b/scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py
@@ -7,18 +7,11 @@
 import great_expectations.expectations as gxe
 
 
-# class PeopleExpectPersonRefColumnValuesToBeUnique(gxe.ExpectColumnValuesToBeUnique):
-#     column: str = "lpar_per_alt_ref"
-#     description: str = "Expect lpar_per_alt_ref (person ref) values to be unique"
-
-
-
 class PeopleExpectPersonRefTenancyRefColumnValuesToBeUnique(gxe.ExpectCompoundColumnsToBeUnique):
-    column_list = ["lpar_per_alt_ref", "lpar_tcy_alt_ref"]
+    column_list: list = ["lpar_per_alt_ref", "lpar_tcy_alt_ref"]
     description: str = "Expect lpar_per_alt_ref (person ref) and lpar_tcy_alt_ref (tenancy ref) values to be unique"
 
 
-
 class PeopleExpectPersonRefColumnValuesToNotBeNull(gxe.ExpectColumnValuesToNotBeNull):
     column: str = "lpar_per_alt_ref"
     description: str = "Expect lpar_per_alt_ref (person ref) values to not be Null"