From d3d1a319d86f58495101ed3c3703bc42941834f3 Mon Sep 17 00:00:00 2001 From: AGibson <4319494+annajgibson@users.noreply.github.com> Date: Mon, 1 Dec 2025 14:05:15 +0000 Subject: [PATCH 1/3] Update test values --- ...migration_properties_data_load_gx_suite.py | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py b/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py index 63ea4fd1f..f97bd794b 100644 --- a/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py +++ b/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py @@ -17,6 +17,28 @@ class PropertiesExpectPropRefColumnValuesToNotBeNull(gxe.ExpectColumnValuesToNot description: str = "Expect lpro_propref (prop ref) values to not be Null" +class PropertiesExpectPropTypeCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet): + column: str = "LPRO_HOU_PTV_CODE" + value_set: list = [ + "BUN", + "CMC", + "CMF", + "COM", + "CYC", + "DUP", + "FLT", + "GAR", + "HOU", + "MAI", + "PRA", + "PSP", + "ROM", + "STD", + "TRV", + ] + description: str = "Expect property type codes to contain one of the set" + + class PropertiesExpectOccStatusCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet): column: str = "lpro_sco_code" value_set: list = ["OCC", "VOI", "CLO"] @@ -149,6 +171,7 @@ class PropertiesExpectPropColumnsToMatchOrderedList( suite = gx.ExpectationSuite(name="properties_data_load_suite") suite.add_expectation(PropertiesExpectPropRefColumnValuesToBeUnique()) +suite.add_expectation(PropertiesExpectPropTypeCodeToBeInSet()) suite.add_expectation(PropertiesExpectOccStatusCodeToBeInSet()) suite.add_expectation(PropertiesExpectOrgIndicatorToBeInSet()) suite.add_expectation(PropertiesExpectOwnTypeToBeInSet()) From d8f29883c28c7c80c668ed775ac71947ba34660d Mon Sep 17 00:00:00 2001 From: AGibson <4319494+annajgibson@users.noreply.github.com> Date: Mon, 1 Dec 2025 14:28:34 +0000 Subject: [PATCH 2/3] Update test values; pause housing GX job --- ...migration_properties_data_load_gx_suite.py | 23 ------------------- 1 file changed, 23 deletions(-) diff --git a/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py b/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py index f97bd794b..63ea4fd1f 100644 --- a/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py +++ b/scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py @@ -17,28 +17,6 @@ class PropertiesExpectPropRefColumnValuesToNotBeNull(gxe.ExpectColumnValuesToNot description: str = "Expect lpro_propref (prop ref) values to not be Null" -class PropertiesExpectPropTypeCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet): - column: str = "LPRO_HOU_PTV_CODE" - value_set: list = [ - "BUN", - "CMC", - "CMF", - "COM", - "CYC", - "DUP", - "FLT", - "GAR", - "HOU", - "MAI", - "PRA", - "PSP", - "ROM", - "STD", - "TRV", - ] - description: str = "Expect property type codes to contain one of the set" - - class PropertiesExpectOccStatusCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet): column: str = "lpro_sco_code" value_set: list = ["OCC", "VOI", "CLO"] @@ -171,7 +149,6 @@ class PropertiesExpectPropColumnsToMatchOrderedList( suite = gx.ExpectationSuite(name="properties_data_load_suite") suite.add_expectation(PropertiesExpectPropRefColumnValuesToBeUnique()) -suite.add_expectation(PropertiesExpectPropTypeCodeToBeInSet()) suite.add_expectation(PropertiesExpectOccStatusCodeToBeInSet()) suite.add_expectation(PropertiesExpectOrgIndicatorToBeInSet()) suite.add_expectation(PropertiesExpectOwnTypeToBeInSet()) From 02771cacd9f38b394f31c78312a57e20c4662246 Mon Sep 17 00:00:00 2001 From: AGibson <4319494+annajgibson@users.noreply.github.com> Date: Tue, 6 Jan 2026 15:41:21 +0000 Subject: [PATCH 3/3] fix field naming issue --- .../housing/housing_nec_migration_people_data_load_gx_suite.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py b/scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py index 279ee8dd6..431ff14a1 100644 --- a/scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py +++ b/scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py @@ -14,7 +14,7 @@ class PeopleExpectPersonRefTenancyRefColumnValuesToBeUnique(gxe.ExpectCompoundColumnsToBeUnique): - column: list = ["lpar_per_alt_ref", "lpar_tcy_alt_ref"] + column_list = ["lpar_per_alt_ref", "lpar_tcy_alt_ref"] description: str = "Expect lpar_per_alt_ref (person ref) and lpar_tcy_alt_ref (tenancy ref) values to be unique"