Cumulative vaccinations appears incorrect

[bryce-carson]

@ashokkrish, in an email you stated that the observed trend in cumulative vaccination is odd.

The old code used the following,

    #--------------------------------------------------------------------#
    # Some susceptible people are going to be newly vaccinated           #
    #--------------------------------------------------------------------#
    newVaccinated <- alpha*valSusceptible
    newVaccinated[valSusceptible < 1] <- 0


    dailyVaccinated <- sum(newVaccinated)

The new code uses this,

spatialEpisim.foundation/R/SVEIRD.BayesianDataAssimilation.R

Line 1030 in 6dd5f47

newVaccinated <- alpha * reclassifyBelowUpperBound(layers$Susceptible, upper = 1)

These are the same, because reclassifyBelowUpperBound reclassifies all values below one to be zero.

How might things be incorrect when the algorithms are (effectively) the same?