Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ version: "3"
vars:
ROOT_DIR:
sh: git rev-parse --show-toplevel
UV_CACHE_DIR: "{{.ROOT_DIR}}/.task-cache/uv"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New cache directory not added to .gitignore

Low Severity

The new .task-cache/uv directory created by uv inside the repository is not listed in .gitignore. After running any of the updated task targets, the cache contents (potentially many wheels and large files) will appear as untracked in git status and could be accidentally added to commits. Adding .task-cache/ to .gitignore would keep the working tree clean.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3c67fc8. Configure here.

DETECTED_LANGUAGES:
sh: |
root="$(git rev-parse --show-toplevel)"
Expand Down Expand Up @@ -89,7 +90,7 @@ tasks:
if [ -n "{{.ACTIVE_PYTHON_PROJECTS}}" ]; then
printf '%s\n' "{{.ACTIVE_PYTHON_PROJECTS}}" | while IFS= read -r pyproject; do
project_dir="$(dirname "${pyproject}")"
(cd "${project_dir}" && uv build)
(cd "${project_dir}" && UV_CACHE_DIR="{{.UV_CACHE_DIR}}" uv build)
done
elif [ -n "{{.PYTHON_PROJECTS}}" ]; then
echo "Skipping Python build by default; set TASK_INCLUDE_PYTHON=1 to include Python projects."
Expand Down Expand Up @@ -120,7 +121,7 @@ tasks:
if [ -d "${project_dir}/tests" ] || find "${project_dir}" \
-maxdepth 1 \
-name 'test_*.py' -print -quit | grep -q .; then
(cd "${project_dir}" && uv run --with pytest pytest)
(cd "${project_dir}" && UV_CACHE_DIR="{{.UV_CACHE_DIR}}" uv run --with pytest pytest)
else
echo "Skipping Python tests in ${project_dir}; no top-level tests found."
fi
Expand Down Expand Up @@ -154,8 +155,8 @@ tasks:
project_dir="$(dirname "${pyproject}")"
(
cd "${project_dir}" &&
uv run --with ruff ruff check . &&
uv run --with ruff ruff format --check .
UV_CACHE_DIR="{{.UV_CACHE_DIR}}" uv run --with ruff ruff check . &&
UV_CACHE_DIR="{{.UV_CACHE_DIR}}" uv run --with ruff ruff format --check .
)
done
elif [ -n "{{.PYTHON_PROJECTS}}" ]; then
Expand Down Expand Up @@ -184,6 +185,7 @@ tasks:
direct_paths = [
root / ".ruff_cache",
root / ".pytest_cache",
root / ".task-cache",
root / "rust" / "target",
]
generated_names = {".venv", "__pycache__", "build", "dist"}
Expand Down
Loading