-
Notifications
You must be signed in to change notification settings - Fork 0
fix(FocalPoint): add serde_json::json import, align clippy MSRV #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
1fbd0d5
adea91b
9a774fa
2e22061
99e0daa
a212e23
d80636c
1d28c48
3cdc998
ca06f9b
5cc0a41
1c74117
bfe430e
0def71c
89e9b85
7ca2080
f3d983e
7e71fe5
4ff8826
edcbc73
4f3a0a5
3ff56e8
6f9fb4d
a71c2ce
52a492c
3172d6c
64db6c7
d6cce19
1670420
38bab10
72df252
f24239e
5d4f1ee
ca4087f
ba7c78a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,69 @@ | ||||||||
| .git | ||||||||
| .gitignore | ||||||||
| *.md | ||||||||
| .env* | ||||||||
| !.env.example | ||||||||
| # Build artifacts | ||||||||
| target/ | ||||||||
| dist/ | ||||||||
| build/ | ||||||||
| *.o | ||||||||
| *.a | ||||||||
| *.so | ||||||||
| # IDE | ||||||||
| .vscode/ | ||||||||
| .idea/ | ||||||||
| *.swp | ||||||||
| .DS_Store | ||||||||
| # Test/nested | ||||||||
| **/node_modules | ||||||||
| **/target | ||||||||
| **/.pytest_cache | ||||||||
| **/__pycache__ | ||||||||
| **/*.test | ||||||||
| **/tests/ | ||||||||
|
cursor[bot] marked this conversation as resolved.
Comment on lines
+18
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Rust integration tests in a 🤖 Prompt for AI Agents |
||||||||
| # Logs | ||||||||
| *.log | ||||||||
| **/*.log | ||||||||
| # Coverage reports | ||||||||
| coverage/ | ||||||||
| .coverage | ||||||||
| *.coverage | ||||||||
| # Python virtual environments | ||||||||
| venv/ | ||||||||
| env/ | ||||||||
| virtualenv/ | ||||||||
| # npm/yarn | ||||||||
| package-lock.json | ||||||||
| yarn.lock | ||||||||
| pnpm-lock.yaml | ||||||||
| # Rust | ||||||||
| **/.cargo | ||||||||
| **/Cargo.lock | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dockerignore excludes
|
||||||||
| **/.cargo | |
| **/Cargo.lock | |
| **/.cargo |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.dockerignore around lines 41 - 42, The .dockerignore currently excludes the
Cargo.lock file via the pattern "**/Cargo.lock"; remove or comment out that
pattern so Cargo.lock is included in the Docker build context (leave other
ignores like "**/.cargo" intact). Ensure the entry "**/Cargo.lock" is deleted or
disabled in .dockerignore so cargo builds inside the image use the committed
Cargo.lock for reproducible dependency resolution.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| blank_issues_enabled: true | ||
| contact_links: | ||
| - name: Phenotype org | ||
| url: https://github.com/KooshaPari | ||
| about: Other Phenotype-ecosystem repos and discussions |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,19 @@ | ||
| name: CI | ||
| on: [push, pull_request] | ||
|
|
||
| permissions: | ||
| contents: read | ||
| actions: read | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable | ||
| with: | ||
| toolchain: 1.85 | ||
| - uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2 | ||
| - run: cargo test --all-features --workspace | ||
| - run: cargo clippy --all-features -- -D warnings 2>/dev/null || cargo check | ||
| - run: cargo clippy --all-features -- -D warnings |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -44,6 +44,10 @@ | |||||||||||||||||||||||||||||||||||||
| default: 'false' | ||||||||||||||||||||||||||||||||||||||
| type: boolean | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| permissions: | ||||||||||||||||||||||||||||||||||||||
| contents: read | ||||||||||||||||||||||||||||||||||||||
|
Check warning on line 48 in .github/workflows/journey-gate.yml
|
||||||||||||||||||||||||||||||||||||||
| actions: read | ||||||||||||||||||||||||||||||||||||||
|
Check warning on line 49 in .github/workflows/journey-gate.yml
|
||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| env: | ||||||||||||||||||||||||||||||||||||||
| PHENOTYPE_JOURNEY_STRICT: ${{ inputs.strict_mode || 'true' }} | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
|
|
@@ -55,7 +59,7 @@ | |||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| steps: | ||||||||||||||||||||||||||||||||||||||
| - name: Checkout | ||||||||||||||||||||||||||||||||||||||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 | ||||||||||||||||||||||||||||||||||||||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| # --------------------------------------------------------------------- | ||||||||||||||||||||||||||||||||||||||
| # 1. Install runtime dependencies | ||||||||||||||||||||||||||||||||||||||
|
|
@@ -126,7 +130,7 @@ | |||||||||||||||||||||||||||||||||||||
| exit 1 | ||||||||||||||||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| COUNT=$(echo "$MANIFESTS" | grep -c . || true) | ||||||||||||||||||||||||||||||||||||||
| COUNT=$(echo "$MANIFESTS" | grep -c .) | ||||||||||||||||||||||||||||||||||||||
| echo "MANIFEST_COUNT=$COUNT" >> $GITHUB_OUTPUT | ||||||||||||||||||||||||||||||||||||||
| echo "MANIFEST_LIST<<EOF" >> $GITHUB_OUTPUT | ||||||||||||||||||||||||||||||||||||||
| echo "$MANIFESTS" >> $GITHUB_OUTPUT | ||||||||||||||||||||||||||||||||||||||
|
|
@@ -177,7 +181,7 @@ | |||||||||||||||||||||||||||||||||||||
| exit 1 | ||||||||||||||||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||||||||||||||||
| else | ||||||||||||||||||||||||||||||||||||||
| phenotype-journey assert "$manifest" || true | ||||||||||||||||||||||||||||||||||||||
| phenotype-journey assert "$manifest" | ||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non-strict journey assertions now fail the buildMedium Severity Removing Reviewed by Cursor Bugbot for commit 6f9fb4d. Configure here. |
||||||||||||||||||||||||||||||||||||||
| echo "(non-strict run — violations do not fail the build)" | ||||||||||||||||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||||||||||||||||
|
Comment on lines
183
to
186
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Stale comment now contradicts behavior — remove or update it. The GitHub Actions shells run with 🛠️ Proposed fix- phenotype-journey assert "$manifest"
- echo "(non-strict run — violations do not fail the build)"
+ phenotype-journey assert "$manifest"
+ echo "(non-strict run — assertion failures still fail the step)"Or, if the intent is truly to keep non-strict mode advisory-only, restore the guard: - phenotype-journey assert "$manifest"
- echo "(non-strict run — violations do not fail the build)"
+ phenotype-journey assert "$manifest" || true
+ echo "(non-strict run — violations do not fail the build)"📝 Committable suggestion
Suggested change
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||
| done | ||||||||||||||||||||||||||||||||||||||
|
|
@@ -234,6 +238,7 @@ | |||||||||||||||||||||||||||||||||||||
| stub-mode: | ||||||||||||||||||||||||||||||||||||||
| name: Journey Gate — No Manifests Found | ||||||||||||||||||||||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||||||||||||||||||||||
| timeout-minutes: 10 | ||||||||||||||||||||||||||||||||||||||
| needs: journey-gate | ||||||||||||||||||||||||||||||||||||||
| if: needs.journey-gate.result == 'failure' && needs.journey-gate.outputs.MANIFEST_COUNT == '0' | ||||||||||||||||||||||||||||||||||||||
| steps: | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,6 @@ pr_details.jsonl | |
|
|
||
| # Rust build artifacts | ||
| /target | ||
|
|
||
| # Example FPL scripts (scaffold output) | ||
| /examples/fpl | ||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial | 💤 Low value
Duplicate exclusion rules for
target/andbuild/.target/(Line 7) andbuild/(Line 9) are already covered at the root level.**/build/(Line 50) and**/target/(Line 51) are redundant.🔧 Proposed cleanup
Also applies to: 50-51
🤖 Prompt for AI Agents