Skip to content

ci: add rust-toolchain.toml reproducible builds #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KooshaPari wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

ci: add rust-toolchain.toml reproducible builds #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[toolchain]
channel = "stable"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR title mentions 'reproducible builds', but using channel = "stable" means the toolchain will automatically update whenever a new stable version of Rust is released. To ensure true reproducibility and align with the MSRV defined in frontend/web/src-tauri/Cargo.toml (which is 1.77.2), you should pin a specific version here.

Suggested change
channel = "stable"
channel = "1.77.2"

Copy link
Copy Markdown

@cursor cursor Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toolchain channel "stable" breaks version detection regex

Medium Severity

Setting channel = "stable" in rust-toolchain.toml breaks the Rust runtime version detection in backend/nvms/lib/awsutil.go, which uses the regex channel = ["'](\d+\.\d+)["'] to extract a numeric version from this file. The string "stable" won't match, so the buildpack will fail to detect the Rust version. Additionally, "stable" doesn't define an MSRV or provide reproducible builds as the PR intends — it floats to whatever the latest stable release is.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 79ff771. Configure here.

components = ["rustfmt", "clippy", "rust-src"]
Loading