Merge branch 'develop'

SebaDro · SebaDro · commit 6290bb3e7d35 · 2026-02-03T13:10:26.000+01:00
diff --git a/processor/process/kommonitor/km_headline_indicator.py b/processor/process/kommonitor/km_headline_indicator.py
@@ -238,7 +238,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
@@ -285,6 +285,8 @@ def run(config: KommonitorProcessConfig,
 
                         if not z_score:
                             ranked = pykmhelper.rank(indicator_obj.lists[time_key])
+                            print(ranked)
+                            print(raw_time)
                             normalized = func(ranked)
                         else:
                             normalized = func(indicator_obj.lists[time_key])
diff --git a/processor/process/kommonitor/km_indicator_absChange_nTemporalItems.py b/processor/process/kommonitor/km_indicator_absChange_nTemporalItems.py
@@ -197,7 +197,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required computation indicator successfully...")
                 
diff --git a/processor/process/kommonitor/km_indicator_absChange_refDate.py b/processor/process/kommonitor/km_indicator_absChange_refDate.py
@@ -169,7 +169,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required computation indicator successfully...")
                 
diff --git a/processor/process/kommonitor/km_indicator_continuity_nTemporalItems.py b/processor/process/kommonitor/km_indicator_continuity_nTemporalItems.py
@@ -199,7 +199,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
                 
diff --git a/processor/process/kommonitor/km_indicator_divide.py b/processor/process/kommonitor/km_indicator_divide.py
@@ -180,7 +180,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/kommonitor/km_indicator_multiply.py b/processor/process/kommonitor/km_indicator_multiply.py
@@ -163,7 +163,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/kommonitor/km_indicator_multiply_value.py b/processor/process/kommonitor/km_indicator_multiply_value.py
@@ -176,7 +176,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/kommonitor/km_indicator_percentage.py b/processor/process/kommonitor/km_indicator_percentage.py
@@ -175,7 +175,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/kommonitor/km_indicator_promille.py b/processor/process/kommonitor/km_indicator_promille.py
@@ -175,7 +175,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/kommonitor/km_indicator_relChange_nTemporalItems.py b/processor/process/kommonitor/km_indicator_relChange_nTemporalItems.py
@@ -200,7 +200,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/kommonitor/km_indicator_relChange_refDate.py b/processor/process/kommonitor/km_indicator_relChange_refDate.py
@@ -171,7 +171,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/kommonitor/km_indicator_share.py b/processor/process/kommonitor/km_indicator_share.py
@@ -175,7 +175,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/kommonitor/km_indicator_subtract.py b/processor/process/kommonitor/km_indicator_subtract.py
@@ -175,7 +175,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/kommonitor/km_indicator_sum.py b/processor/process/kommonitor/km_indicator_sum.py
@@ -160,7 +160,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/kommonitor/km_indicator_trend_nTemporalItems.py b/processor/process/kommonitor/km_indicator_trend_nTemporalItems.py
@@ -201,7 +201,7 @@ def run(config: KommonitorProcessConfig,
 
                 # get the intersection of all applicable su_features and check for missing spatial unit feature error
                 collection.find_intersection_applicable_su_features()
-                collection.check_applicable_spatial_unit_features(job_summary)
+                all_times = collection.check_applicable_spatial_unit_features(job_summary, all_times)
 
                 logger.debug("Retrieved required indicators successfully")
 
diff --git a/processor/process/pykmhelper.py b/processor/process/pykmhelper.py
@@ -1142,8 +1142,9 @@ def check_applicable_target_dates(self, job_summary: KommonitorJobSummary):
             if self.indicators[indicator].bool_missing_timestamp:
                 job_summary.add_missing_timestamp_error("INDICATOR", indicator, self.indicators[indicator].missing_timestamps)
 
-    def check_applicable_spatial_unit_features(self, job_summary: KommonitorJobSummary):
+    def check_applicable_spatial_unit_features(self, job_summary: KommonitorJobSummary, allDates: list):
         """checks whether spatial unit features are missing for certain indicators and in this case adds a missing timestamp error to the jobSummary
+        also checks whether a timestamp has only NONE values for each spatial unit feature and adds a missing spatial unit feature.
 
         Args:
             job_summary (KommonitorJobSummary): the current kommonitor jobSummary
@@ -1157,6 +1158,22 @@ def check_applicable_spatial_unit_features(self, job_summary: KommonitorJobSumma
             if len(missing_su_features) > 0:
                 job_summary.add_missing_spatial_unit_feature_error(indicator, missing_su_features)
 
+        for indicator in self.indicators:
+
+            for i, date in enumerate(allDates):
+                date_with_prefix = getTargetDateWithPropertyPrefix(date)
+                for feature in self.all_su_features:
+                    emptyTimeSeries = True
+                    if not isNoDataValue(self.indicators[indicator].time_series[feature][date_with_prefix]):
+                        emptyTimeSeries = False
+                        break
+
+                if emptyTimeSeries:
+                    job_summary.add_missing_timestamp_error("INDICATOR", indicator, [date])
+                    allDates.pop(i)
+
+        return allDates
+
     def fetch_indicator_feature_time_series(self):
         """creates a time series which allows direct access to the data using indicator id and su feature id and target date
         """
@@ -3037,7 +3054,11 @@ def getChange_absolute(feature, targetDate, compareDate):
     targetDatePrefix = getTargetDateWithPropertyPrefix(targetDate)
     compareDatePrefix = getTargetDateWithPropertyPrefix(compareDate)
     targetValue = feature[targetDatePrefix]
-    compareValue = feature[compareDatePrefix]
+    try:
+        compareValue = feature[compareDatePrefix]
+    except KeyError:
+        throwError(f"An error occured because the target value {targetDate} has no compare value in the feature collection.")
+        resultValue = None
 
     if not isNoDataValue(compareValue) and not isNoDataValue(targetValue):
         resultValue = float(targetValue) - float(compareValue)
