Fix: add validation for config.json#52
Open
SyedaAnshrahGillani wants to merge 1 commit intoKittenML:mainfrom
Open
Fix: add validation for config.json#52SyedaAnshrahGillani wants to merge 1 commit intoKittenML:mainfrom
SyedaAnshrahGillani wants to merge 1 commit intoKittenML:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes to prevent such crashes and provide
clearer feedback to the user:
configuration dictionary, preventing KeyError exceptions.
model_file, and voices) and raises a ValueError with a clear, informative
message if any are missing.
unsupported model type to be more specific and helpful for debugging.
These changes make the model loading logic more resilient to invalid
configurations and improve the overall user experience by providing
actionable error messages.