Merge pull request #94 from Kit/php-8.4-compat

Run Tests and Coding Standards against PHP 8.4

Author: n7studios

.github/workflows/tests.yml

@@ -47,7 +47,7 @@ jobs:
       fail-fast: false
       matrix:
         wp-versions: [ 'latest' ] #[ 'latest', '6.1.1' ]
-        php-versions: [ '7.4', '8.0', '8.1', '8.2', '8.3' ] #[ '7.4', '8.0', '8.1', '8.2' ]
+        php-versions: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ] #[ '7.4', '8.0', '8.1', '8.2' ]
 
     # Steps to install, configure and run tests
     steps:

src/class-convertkit-api-traits.php

@@ -135,7 +135,7 @@ public function get_email_stats()
      *
      * @return false|mixed
      */
-    public function get_growth_stats(\DateTime $starting = null, \DateTime $ending = null)
+    public function get_growth_stats(?\DateTime $starting = null, ?\DateTime $ending = null)
     {
         return $this->get(
             'account/growth_stats',
@@ -339,10 +339,10 @@ public function add_subscriber_to_legacy_form(int $form_id, int $subscriber_id)
     public function get_form_subscriptions(
         int $form_id,
         string $subscriber_state = 'active',
-        \DateTime $created_after = null,
-        \DateTime $created_before = null,
-        \DateTime $added_after = null,
-        \DateTime $added_before = null,
+        ?\DateTime $created_after = null,
+        ?\DateTime $created_before = null,
+        ?\DateTime $added_after = null,
+        ?\DateTime $added_before = null,
         bool $include_total_count = false,
         string $after_cursor = '',
         string $before_cursor = '',
@@ -466,10 +466,10 @@ public function add_subscriber_to_sequence(int $sequence_id, int $subscriber_id)
     public function get_sequence_subscriptions(
         int $sequence_id,
         string $subscriber_state = 'active',
-        \DateTime $created_after = null,
-        \DateTime $created_before = null,
-        \DateTime $added_after = null,
-        \DateTime $added_before = null,
+        ?\DateTime $created_after = null,
+        ?\DateTime $created_before = null,
+        ?\DateTime $added_after = null,
+        ?\DateTime $added_before = null,
         bool $include_total_count = false,
         string $after_cursor = '',
         string $before_cursor = '',
@@ -682,10 +682,10 @@ public function remove_tag_from_subscriber_by_email(int $tag_id, string $email_a
     public function get_tag_subscriptions(
         int $tag_id,
         string $subscriber_state = 'active',
-        \DateTime $created_after = null,
-        \DateTime $created_before = null,
-        \DateTime $tagged_after = null,
-        \DateTime $tagged_before = null,
+        ?\DateTime $created_after = null,
+        ?\DateTime $created_before = null,
+        ?\DateTime $tagged_after = null,
+        ?\DateTime $tagged_before = null,
         bool $include_total_count = false,
         string $after_cursor = '',
         string $before_cursor = '',
@@ -781,10 +781,10 @@ public function get_email_templates(
     public function get_subscribers(
         string $subscriber_state = 'active',
         string $email_address = '',
-        \DateTime $created_after = null,
-        \DateTime $created_before = null,
-        \DateTime $updated_after = null,
-        \DateTime $updated_before = null,
+        ?\DateTime $created_after = null,
+        ?\DateTime $created_before = null,
+        ?\DateTime $updated_after = null,
+        ?\DateTime $updated_before = null,
         string $sort_field = 'id',
         string $sort_order = 'desc',
         bool $include_total_count = false,
@@ -1128,8 +1128,8 @@ public function create_broadcast(
         string $content = '',
         string $description = '',
         bool $public = false,
-        \DateTime $published_at = null,
-        \DateTime $send_at = null,
+        ?\DateTime $published_at = null,
+        ?\DateTime $send_at = null,
         string $email_address = '',
         string $email_template_id = '',
         string $thumbnail_alt = '',
@@ -1236,8 +1236,8 @@ public function update_broadcast(
         string $content = '',
         string $description = '',
         bool $public = false,
-        \DateTime $published_at = null,
-        \DateTime $send_at = null,
+        ?\DateTime $published_at = null,
+        ?\DateTime $send_at = null,
         string $email_address = '',
         string $email_template_id = '',
         string $thumbnail_alt = '',
@@ -1619,14 +1619,14 @@ public function create_purchase(
         string $transaction_id,
         array $products,
         string $currency = 'USD',
-        string $first_name = null,
-        string $status = null,
+        ?string $first_name = null,
+        ?string $status = null,
         float $subtotal = 0,
         float $tax = 0,
         float $shipping = 0,
         float $discount = 0,
         float $total = 0,
-        \DateTime $transaction_time = null
+        ?\DateTime $transaction_time = null
     ) {
         // Build parameters.
         $options = [