From 3c01d6595805eeb13775547635561ab862a1f5f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0imon?= <95319163+wpsimon09@users.noreply.github.com> Date: Thu, 29 Jan 2026 10:14:44 +0100 Subject: [PATCH 1/3] Removed out of context sentence and improved a clarity of device creation parameters One sentence seemed to be out of place, which I have replaced with another sentence that followed up on the code behind it. Lastly the information about parameters passed to the `vk::raii::Device()` were all in one sentence which was quite difficult to read. --- .../00_Setup/04_Logical_device_and_queues.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc b/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc index 0b093671..d6130c78 100644 --- a/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc +++ b/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc @@ -165,7 +165,7 @@ link:https://docs.vulkan.org/spec/latest/chapters/raytracing.html#extendingvulka That means that the `enabledLayerCount` and `ppEnabledLayerNames` fields of `VkDeviceCreateInfo` are ignored by up-to-date implementations. -As mentioned earlier, we need several device-specific extensions for our application to work properly. +With the `vk::DeviceCreateInfo` filled in, we can now proceede with creating logical device. [,c++] ---- @@ -173,7 +173,7 @@ device = vk::raii::Device( physicalDevice, deviceCreateInfo ); ---- The parameters are the physical device to interface with, and the usage -info we just specified, the optional allocation callbacks pointer and a pointer +info we just specified. Additional and optional parameters are the allocation callbacks pointer and a pointer to a variable to store the logical device handle in. Similarly to the instance creation function, this call can throw errors based on enabling non-existent extensions or specifying the desired usage of unsupported features. From 3b906a7a63af489005d498b247159d7bfd0d6e10 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0imon?= <95319163+wpsimon09@users.noreply.github.com> Date: Thu, 29 Jan 2026 10:27:34 +0100 Subject: [PATCH 2/3] Fix typos and enhance logical device creation details Corrected typos and improved clarity in the explanation of logical device creation. --- .../00_Setup/04_Logical_device_and_queues.adoc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc b/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc index d6130c78..9e06a7bf 100644 --- a/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc +++ b/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc @@ -165,17 +165,17 @@ link:https://docs.vulkan.org/spec/latest/chapters/raytracing.html#extendingvulka That means that the `enabledLayerCount` and `ppEnabledLayerNames` fields of `VkDeviceCreateInfo` are ignored by up-to-date implementations. -With the `vk::DeviceCreateInfo` filled in, we can now proceede with creating logical device. +With the `vk::DeviceCreateInfo` filled in, we can now proceed with creating logical device. [,c++] ---- device = vk::raii::Device( physicalDevice, deviceCreateInfo ); ---- -The parameters are the physical device to interface with, and the usage -info we just specified. Additional and optional parameters are the allocation callbacks pointer and a pointer -to a variable to store the logical device handle in. Similarly to the instance -creation function, this call can throw errors based on enabling non-existent +Passed parameters are the physical device to interface with, and the create +info we`ve just specified. Additional and optional parameters include the allocation callbacks pointer and a pointer +specifying where to store the created logical device handle. In our case the function call returns the `vk::Device` handle directly. +Similarly to the instance creation function, this call can throw errors based on enabling non-existent extensions or specifying the desired usage of unsupported features. Logical devices don't interact directly with instances, which is why it's not From 4aba80a31c9724eae181e4f07ad7db5241f779ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0imon?= <95319163+wpsimon09@users.noreply.github.com> Date: Thu, 29 Jan 2026 10:31:43 +0100 Subject: [PATCH 3/3] Added , --- .../00_Setup/04_Logical_device_and_queues.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc b/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc index 9e06a7bf..79a49634 100644 --- a/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc +++ b/en/03_Drawing_a_triangle/00_Setup/04_Logical_device_and_queues.adoc @@ -174,7 +174,7 @@ device = vk::raii::Device( physicalDevice, deviceCreateInfo ); Passed parameters are the physical device to interface with, and the create info we`ve just specified. Additional and optional parameters include the allocation callbacks pointer and a pointer -specifying where to store the created logical device handle. In our case the function call returns the `vk::Device` handle directly. +specifying where to store the created logical device handle. In our case, the function call returns the `vk::Device` handle directly. Similarly to the instance creation function, this call can throw errors based on enabling non-existent extensions or specifying the desired usage of unsupported features.