Open
Conversation
Member
|
Thanks for the PR! I don't mind moving off of nightly, but I think I can't accept this PR for two reasons:
Ideally, if we pick a third-party SIMD library, it should also support scatters and gathers (though on most hardware those ops are effectively sequential). |
Author
|
I understand. You could use some basic conditional compiling to implement your own gather. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rough pass on using
wideinstead ofportable_simdfor vectorized operations.It passes all the tests and seems comparable on benchmarks
Portable Simd
Wide
Full disclosure the first pass of this was done using claude code with bug fixes and regressions being tracked down manually.