Skip to content

Commit 2927970

Browse files
committed
feat: Update sample project configuration and add missing resources
1 parent 65359b5 commit 2927970

5 files changed

Lines changed: 18 additions & 3 deletions

File tree

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,7 @@ src/**/Native/Android/build/
3030
# Sample local config
3131
samples/**/google-services.json
3232
samples/**/secrets.*
33+
34+
# Sample generated files
35+
samples/**/AndroidManifest.xml
36+
samples/**/strings.xml

samples/Kapusch.Facebook.Android.Sample/Kapusch.Facebook.Android.Sample.csproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
</Target>
2323
<PropertyGroup>
2424
<_SampleStrings>$(MSBuildThisFileDirectory)Resources/values/strings.xml</_SampleStrings>
25-
<_SampleStringsTemplate>$(MSBuildThisFileDirectory)Resources/values/strings.template.xml</_SampleStringsTemplate>
25+
<_SampleStringsTemplate>$(MSBuildThisFileDirectory)Resources/values/strings.template</_SampleStringsTemplate>
2626
</PropertyGroup>
2727
<Target Name="KapuschFacebookSample_EnsureStrings" BeforeTargets="PrepareForBuild">
2828
<Copy
@@ -31,6 +31,10 @@
3131
DestinationFiles="$(_SampleStrings)"
3232
/>
3333
</Target>
34+
<ItemGroup>
35+
<PackageReference Include="Xamarin.AndroidX.AppCompat" Version="1.7.1.1" />
36+
<PackageReference Include="Xamarin.AndroidX.CardView" Version="1.0.0.36" />
37+
</ItemGroup>
3438
<ItemGroup>
3539
<ProjectReference Include="$(MSBuildThisFileDirectory)../../src/Kapusch.FacebookApisForAndroidComponents/Kapusch.FacebookApisForAndroidComponents.csproj" />
3640
</ItemGroup>

samples/Kapusch.Facebook.Android.Sample/Resources/values/strings.template.xml renamed to samples/Kapusch.Facebook.Android.Sample/Resources/values/strings.template

File renamed without changes.

samples/Kapusch.Facebook.Android.Sample/src/MainActivity.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,15 @@ protected override void OnCreate(Bundle? savedInstanceState)
1818
var button = new Button(this) { Text = "Start Facebook Login" };
1919
button.Click += (_, _) =>
2020
{
21+
var packageName = PackageName;
22+
if (string.IsNullOrWhiteSpace(packageName))
23+
{
24+
Toast.MakeText(this, "Missing package name", ToastLength.Short)?.Show();
25+
return;
26+
}
27+
2128
var intent = new Intent();
22-
intent.SetClassName(PackageName, AndroidFacebookInterop.LoginActivityClassName);
29+
intent.SetClassName(packageName, AndroidFacebookInterop.LoginActivityClassName);
2330
StartActivityForResult(intent, LoginRequestCode);
2431
};
2532

src/Kapusch.FacebookApisForAndroidComponents/Native/Android/facebookinterop/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ android {
77
compileSdk = 34
88

99
defaultConfig {
10-
minSdk = 26
10+
minSdk = 21
1111
consumerProguardFiles("consumer-rules.pro")
1212
}
1313

0 commit comments

Comments
 (0)