-
Notifications
You must be signed in to change notification settings - Fork 47
Open
Description
Issue description:
Right now joining leaks the server(and port on which it's running) and player ID to google-analytics
CustomNPC-Plus/src/main/java/noppes/npcs/ServerTickHandler.java
Lines 41 to 47 in 7a4ced1
| e += ":" + server.getPort(); | |
| } | |
| if (e == null || e.startsWith("192.168") || e.contains("127.0.0.1") || e.startsWith("localhost")) | |
| e = "local"; | |
| serverName = e; | |
| } | |
| AnalyticsTracking.sendData(event.player, "join", serverName); |
| UUID uuid = player.getUniqueID(); | |
| String analyticsPostData = "v=1" + | |
| "&tid=UA-29079943-5" + | |
| "&cid=" + uuid.toString() + | |
| "&t=event" + | |
| "&ec=customnpcs_1.7d" + | |
| "&ea=" + event + | |
| "&el=" + data + | |
| "&ev=300"; | |
| URL url = new URL("http://www.google-analytics.com/collect"); | |
| HttpURLConnection connection = (HttpURLConnection) url.openConnection(); |
This is not necessary, not configurable(compare to version checker)
and it sends data to original customnpc mod anyway
Metadata
Metadata
Assignees
Labels
No labels