Fix test failures caused by upstream HTTP.jl switching version fields from VersionNumber to HTTPVersion#30
Merged
DilumAluthge merged 1 commit intoMar 31, 2026
Conversation
DilumAluthge-LLM
force-pushed
the
codex/julia-1-12-test-fixes
branch
from
d818c0a to
a97e0de
Compare
DilumAluthge-LLM
changed the title
DilumAluthge-LLM
force-pushed
the
codex/julia-1-12-test-fixes
branch
from
fb274eb to
c45fedf
Compare
DilumAluthge-LLM
changed the title
DilumAluthge-LLM
changed the title
DilumAluthge-LLM
force-pushed
the
codex/julia-1-12-test-fixes
branch
from
b2b3085 to
872e270
Compare
… from VersionNumber to HTTPVersion Normalize stored HTTP version values so BrokenRecord no longer depends on HTTP.jl's internal string representation, and format HTTPVersion values via VersionNumber to preserve the historical x.y.0 serialized form. Co-authored-by: OpenAI Codex GPT-5 <codex@openai.com>
DilumAluthge-LLM
force-pushed
the
codex/julia-1-12-test-fixes
branch
from
872e270 to
4391fba
Compare
Member
|
I have manually reviewed the code in this PR. |
Member
|
@quinnj @christopher-dG Could you review this? It fixes the CI failures currently seen on master. |
1 task
quinnj
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the test failure seen in e.g. #29.
In the past,
HTTP.jlstored versions asVersionNumber, sostring(resp.version)produced"1.1.0".However, now
HTTP.jlstores versions asHTTPVersion, sostring(resp.version)produces"HTTPVersion(\"1.1\")".After this PR, we correctly get the string
"1.1"regardless of whether HTTP.jl stores it asHTTPVersionorVersionNumber.🤖 Generated by OpenAI Codex.