Merge branch 'master' into spj/updateci

Author: ScottPJones

src/legacy.jl

@@ -4,8 +4,8 @@
 
 # Renamed from ascii to to_ascii, to prevent issues with Base.ascii
 to_ascii(str) = convert(ASCIIStr, str)
-to_ascii(pnt::Ptr{UInt8}) = convert(ASCIIStr, unsafe_string(p))
-to_ascii(pnt::Ptr{UInt8}, len::Integer) = convert(ASCIIStr, unsafe_string(p, len))
+to_ascii(p::Ptr{UInt8}) = convert(ASCIIStr, unsafe_string(p))
+to_ascii(p::Ptr{UInt8}, len::Integer) = convert(ASCIIStr, unsafe_string(p, len))
 
 """
     utf8(s)

test/basic.jl

@@ -16,6 +16,11 @@ end
 
 string_types = keys(compat_types)
 
+legacy_types = Dict(ASCIIStr => to_ascii,
+                    UTF8Str => utf8,
+                    UTF16Str => utf16,
+                    UTF32Str => utf32)
+
 ##  create type specific test strings
 test_strings_base = Dict()
 for T in AllCharTypes
@@ -28,6 +33,14 @@ end
     end
 end
 
+@testset "legacy constructors" begin
+    for (ST, constructor) in legacy_types, str in test_strings_base[ASCIIChr]
+        vec = Vector{codeunit(ST)}(codeunits(str))
+        @eval @test $constructor($vec) == $str
+        @eval @test $constructor(pointer($vec), $(length(vec))) == $str
+    end
+end
+
 @testset "empty strings" begin
     for ST in keys(compat_types)
         @eval @test is_empty(convert($ST, ""))