A few more tests and Compat stuff for 0.7 (#133)

* A few more tests and Compat stuff for 0.7

* Use !iszero

Author: kshyatt

REQUIRE

@@ -1,2 +1,2 @@
 julia 0.6
-Compat 0.39.0
+Compat 0.48.0

src/Polynomials.jl

@@ -13,10 +13,11 @@ export polyval, polyint, polyder, roots, polyfit
 export Pade, padeval
 
 import Base: start, next, done, length, size, eltype, collect, eachindex
-import Base: endof, getindex, setindex!, copy, zero, one, convert, norm, gcd
+import Base: endof, getindex, setindex!, copy, zero, one, convert, gcd
 import Base: show, print, *, /, //, -, +, ==, isapprox, divrem, div, rem, eltype
-import Base: promote_rule, truncate, chop,  conj, transpose, dot, hash
+import Base: promote_rule, truncate, chop,  conj, transpose, hash
 import Base: isequal
+import Compat.LinearAlgebra: norm, dot, eigvals, diagm, vecnorm, qrfact
 
 const SymbolLike = Union{AbstractString,Char,Symbol}
 
@@ -79,7 +80,8 @@ struct Poly{T}
       return new{T}(zeros(T,1),Symbol(var))
     else
       # determine the last nonzero element and truncate a accordingly
-      a_last = max(1,findlast(x->x!=zero(T), a))
+      last_nz = findlast(!iszero, a)
+      a_last = max(1, last_nz === nothing ? 0 : last_nz)
       new{T}(a[1:a_last], Symbol(var))
     end
   end

test/runtests.jl

@@ -1,8 +1,11 @@
 # assert file to test polynomial implementation
 using Compat
 using Compat.Test
+using Compat.LinearAlgebra
 using Polynomials
 
+import Compat.SparseArrays: sparse, speye, nnz
+
 pNULL = Poly(Float32[])
 p0 = Poly([0])
 p1 = Poly([1,0,0,0,0,0,0,0,0,0,0,0,0,0])
@@ -27,6 +30,8 @@ p1000 = Poly(randn(1000))
 sprint(show, p1000)
 sprint(show, pNULL)
 
+@test Poly([1, -2, 1]) == poly(diagm(0=>[1., 1.]))
+
 @test p3 == Poly([1,2,1])
 @test pN*10 == Poly([2760, 30, 870, 150, 240])
 @test pN/10 == Poly([27.6, 0.3, 8.7, 1.5, 2.4])
@@ -164,6 +169,8 @@ psum = p1 + p2 - p3
 @test truncate(Poly([2,1]),reltol=1,abstol=0)   == Poly([0])
 @test truncate(Poly([2,1]),reltol=0,abstol=1)   == Poly([2])
 
+@test norm(Poly([1., 2.])) == norm([1., 2.])
+@test norm(Poly([1., 2.]), 1) == norm([1., 2.], 1)
 
 ## setindex!
 println("Test for setindex!()")
@@ -205,6 +212,8 @@ as = [im, 1, 2]
 bs = [1, 1, 2]
 @test conj(Poly(as)) == Poly(conj(as))
 @test conj(Poly(bs)) == Poly(conj(bs))
+## and transpose
+@test transpose(Poly(as)) == Poly(as)
 
 ## unnecessary copy in convert #65
 p1 = Poly([1,2])