v1.2 for numerical too

Author: jverzani

src/polynomials/ngcd.jl

@@ -133,7 +133,7 @@ by Zhonggang Zeng;
 [url](http://homepages.neiu.edu/~zzeng/uvgcd.pdf);
 [doi](https://doi.org/10.1090/conm/556/11014)
 
-Note: Based on work by Andreas Varga
+Note: Based on work by Andreas Varga; Requires `VERSION >= v"1.2"`.
 
 """
 function ngcd(ps::Vector{T},

test/StandardBasis.jl

@@ -692,8 +692,10 @@ end
     d = P([0.5490673726445683, 0.15991109487875477]);
     @test degree(gcd(a*d,b*d)) == 0
     @test degree(gcd(a*d, b*d, atol=sqrt(eps()))) > 0
-    VERSION >= v"1.2.0" &&  @test  degree(gcd(a*d,b*d, method=:noda_sasaki)) == degree(d)
-    @test degree(gcd(a*d,b*d, method=:numerical)) == degree(d)
+    if VERSION >= v"1.2.0"
+        @test  degree(gcd(a*d,b*d, method=:noda_sasaki)) == degree(d)
+        @test degree(gcd(a*d,b*d, method=:numerical)) == degree(d)
+    end
 
     l,m,n = (5,5,5) # realiable, though for larger l,m,n only **usually** correct
     u,v,w = fromroots.(rand.((l,m,n)))
@@ -705,49 +707,52 @@ end
     q = (x+10)*(x^9 + x^8/7 - 6//7)
 
     @test degree(gcd(p,q)) == 0
-    VERSION >= v"1.2.0"  && (@test degree(gcd(p,q, method=:noda_sasaki)) == 1)
-    @test degree(gcd(p,q, method=:numerical)) == 1
-
-    # more bits don't help Euclidean
-    x = variable(P{BigFloat})
-    p = (x+10)*(x^9 + x^8/3 + 1)
-    q = (x+10)*(x^9 + x^8/7 - 6//7)
-    @test degree(gcd(p,q)) == 0
-
-    # Test 1 of Zeng
-    x =  variable(P{Float64})
-    alpha(j,n) = cos(j*pi/n)
-    beta(j,n) = sin(j*pi/n)
-    r1, r2 = 1/2, 3/2
-    U(n) = prod( (x-r1*alpha(j,n))^2 + r1^2*beta(j,n)^2 for j in 1:n)
-    V(n) = prod( (x-r2*alpha(j,n))^2 + r2^2*beta(j,n)^2 for j in 1:n)
-    W(n) = prod( (x-r1*alpha(j,n))^2 + r1^2*beta(j,n)^2 for j in (n+1):2n)
-    for n in 2:2:20
-        p = U(n) * V(n); q = U(n) * W(n)
-        @test degree(gcd(p,q, method=:numerical)) == degree(U(n))
-    end
-
-    # Test 5 of Zeng
-    x =  variable(P{Float64})
-    for ms in ((2,1,1,0), (3,2,1,0), (4,3,2,1), (5,3,2,1), (9,6,4,2),
-               (20, 14, 10, 5), (80,60,40,20), (100,60,40,20)
-               )
+    if VERSION >= v"1.2.0"
+        (@test degree(gcd(p,q, method=:noda_sasaki)) == 1)
+        @test degree(gcd(p,q, method=:numerical)) == 1
+    end
+
+    if VERSION >= v"1.2.0"
+        # more bits don't help Euclidean
+        x = variable(P{BigFloat})
+        p = (x+10)*(x^9 + x^8/3 + 1)
+        q = (x+10)*(x^9 + x^8/7 - 6//7)
+        @test degree(gcd(p,q)) == 0
+        
+        # Test 1 of Zeng
+        x =  variable(P{Float64})
+        alpha(j,n) = cos(j*pi/n)
+        beta(j,n) = sin(j*pi/n)
+        r1, r2 = 1/2, 3/2
+        U(n) = prod( (x-r1*alpha(j,n))^2 + r1^2*beta(j,n)^2 for j in 1:n)
+        V(n) = prod( (x-r2*alpha(j,n))^2 + r2^2*beta(j,n)^2 for j in 1:n)
+        W(n) = prod( (x-r1*alpha(j,n))^2 + r1^2*beta(j,n)^2 for j in (n+1):2n)
+        for n in 2:2:20
+            p = U(n) * V(n); q = U(n) * W(n)
+            @test degree(gcd(p,q, method=:numerical)) == degree(U(n))
+        end
+        
+        # Test 5 of Zeng
+        x =  variable(P{Float64})
+        for ms in ((2,1,1,0), (3,2,1,0), (4,3,2,1), (5,3,2,1), (9,6,4,2),
+                   (20, 14, 10, 5), (80,60,40,20), (100,60,40,20)
+                   )
+            
+            p = prod((x-i)^j for (i,j) in enumerate(ms))
+            dp = derivative(p)
+            @test degree(gcd(p,dp, method=:numerical)) == sum(max.(ms .- 1, 0))
+        end
+        
+        # fussy pair
+        x =  variable(P{Float64})
+        for n in (2,5,10,20,50, 100)
+            p = (x-1)^n * (x-2)^n * (x-3)
+            q = (x-1) * (x-2) * (x-4)
+            @test degree(gcd(p,q, method=:numerical)) == 2  
+        end
+        
+    end 
 
-        p = prod((x-i)^j for (i,j) in enumerate(ms))
-        dp = derivative(p)
-        @test degree(gcd(p,dp, method=:numerical)) == sum(max.(ms .- 1, 0))
-    end
-    
-    # fussy pair
-    x =  variable(P{Float64})
-    for n in (2,5,10,20,50, 100)
-        p = (x-1)^n * (x-2)^n * (x-3)
-        q = (x-1) * (x-2) * (x-4)
-        @test degree(gcd(p,q, method=:numerical)) == 2  
-    end
-    
-    
-    
 end