I think when use_fitpos = true, the centroids should only be updated in the case that the PSF fit converged successfully; if PSF fits fail to converge, they can then poison the resulting catalog if use_fitpos is true (see e.g. https://github.com/JuliaAstro/Astroalign.jl/actions/runs/24008508904/job/70016102696?pr=28 which fails when fitpos=true (default) but passes when fitpos = false)
I think when
use_fitpos = true, the centroids should only be updated in the case that the PSF fit converged successfully; if PSF fits fail to converge, they can then poison the resulting catalog ifuse_fitposis true (see e.g. https://github.com/JuliaAstro/Astroalign.jl/actions/runs/24008508904/job/70016102696?pr=28 which fails whenfitpos=true(default) but passes whenfitpos = false)