You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to a recent change in ScientificTypesBase,jl from version 2.0 to 3.0, the ScientifictypesBase.scitype method is now a two argument method. Packages depending on MLJModelInterface.jl previously depended on the previous one argument version defined in version 2.0 series of ScientifictypesBase package.
A workaround is needed to avoid making MLJModelInterface breaking for its's users. This involves
Defining a one argument scitype method in MLJModelInterface. Something in the lines of
scitype(X) =scitype(get_interface_mode(), X)
scitype(::LightInterface, X) =throw(ArgumentError("FullInterface is needed..."))
The corresponding FullInterface method would be implemented at MLJBase/src/Interface/data_utils.jl.
But implementing the second step also leads to method import clashes with ScientificTypes.scitype at MLJBase. For now a hack at MLJBase/src/MLJBase.jl fixes this issue, but going forward the scitype method shouldn't be exported. Hence users that want to use the scitype method would have to qualify it with the package name e.g. MLJModelinterface.scitype(X).
Due to a recent change in
ScientificTypesBase,jlfrom version 2.0 to 3.0, theScientifictypesBase.scitypemethod is now a two argument method. Packages depending onMLJModelInterface.jlpreviously depended on the previous one argument version defined in version 2.0 series ofScientifictypesBasepackage.A workaround is needed to avoid making
MLJModelInterfacebreaking for its's users. This involvesscitypemethod in MLJModelInterface. Something in the lines ofThe corresponding
FullInterfacemethod would be implemented atMLJBase/src/Interface/data_utils.jl.scitypemethod atMLJModelInterface(Needed as users expect that thescitypemethod is exported. see MLJModelInterface no longer exportingscitype#129 )But implementing the second step also leads to method import clashes with
ScientificTypes.scitypeat MLJBase. For now a hack at MLJBase/src/MLJBase.jl fixes this issue, but going forward thescitypemethod shouldn't be exported. Hence users that want to use thescitypemethod would have to qualify it with the package name e.g.MLJModelinterface.scitype(X).