[JULES] refactor(architecture): Fix layering violations - ARCH-002

[JuanCS-Dev]

Task Type

refactor - Architecture fix

Component

agents.coder, agents.devops

Problem Description

Domain layer (agents/) imports from CLI layer (vertice_cli/), violating clean architecture principles. Dependencies should flow inward: CLI → Core, not Core → CLI.

Violations Found

1. agents/coder/agent.py:41 - imports from vertice_cli.agents
2. agents/devops/agent.py:251 - imports from vertice_cli.tools

Files to Modify

• agents/coder/agent.py:41 - Fix import
• agents/devops/agent.py:251 - Fix import

Current Code (Problematic)

# agents/coder/agent.py:41
from vertice_cli.agents.architect import ArchitectAgent  # WRONG: domain imports CLI

# agents/devops/agent.py:251
from vertice_cli.tools.registry import ToolRegistry  # WRONG: domain imports CLI

Expected Code (Fix)

Option 1: Move shared code to vertice_core

# agents/coder/agent.py
from vertice_core.agents import ArchitectAgent  # Correct: imports from core

# agents/devops/agent.py
from vertice_core.tools import ToolRegistry  # Correct: imports from core

Option 2: Use protocol/interface

# agents/coder/agent.py
from typing import Protocol

class ArchitectProtocol(Protocol):
    async def analyze(self, code: str) -> AnalysisResult: ...

# Inject concrete implementation from CLI layer

Validation Commands

# Check imports
python3 -c "from agents.coder.agent import CoderAgent; print('OK')"
python3 -c "from agents.devops.agent import DevOpsAgent; print('OK')"

# Verify no CLI imports in agents/
grep -rn "from vertice_cli" agents/ --include="*.py"

# Run agent tests
pytest tests/agents/ -v

Priority

high

References

• Clean Architecture
• Audit ID: ARCH-002

[google-labs-jules]

You are currently at your limit of 3 running tasks. Either wait for a task to finish or pause a task from the dashboard, then reassign this issue. See rate limit documentation for more information.

[google-labs-jules]

Jules is on it. When finished, you will see another comment and be able to review a PR.

[google-labs-jules]

I apologize, but I encountered an unexpected error and wasn't able to complete the task.

[google-labs-jules]

You are currently at your limit of 15 tasks in 24 hours. This issue can be reassigned once your quota resets. See rate limit documentation for more information.

[JuanCS-Dev]

@jules please fix these architecture layering violations.