adding tests

Author: Tilo Sloboda

lib/json_api_client/errors.rb

@@ -107,11 +107,11 @@ def initialize(code, uri)
     class RecordNotSaved < ServerError
       attr_reader :record
 
-      def initialize(record = nil)
+      def initialize(message = nil, record = nil)
         @record = record
-        msg = 'Record not saved'
-
-        super nil, msg
+      end
+      def message
+        "Record not saved"
       end
     end
   end

test/unit/creation_test.rb

@@ -66,6 +66,23 @@ def test_can_create_with_class_method
     assert_equal "Rails is Omakase", article.title
   end
 
+  def test_failed_create!
+    stub_request(:post, "http://example.com/users")
+      .to_return(headers: {content_type: "application/vnd.api+json"}, body: {
+        errors: [
+          {
+            status: "400",
+            title: "Error"
+          }
+        ]
+      }.to_json)
+
+    exception = assert_raises JsonApiClient::Errors::RecordNotSaved do
+      User.create!(name: 'Hans')
+    end
+    assert_equal "Record not saved", exception.message
+  end
+
   def test_changed_attributes_empty_after_create_with_class_method
     stub_simple_creation
     article = Article.create({

test/unit/updating_test.rb

@@ -36,6 +36,36 @@ def stub_simple_fetch
       }.to_json)
   end
 
+  def test_failed_update!
+    stub_simple_fetch
+    articles = Article.find(1)
+    article = articles.first
+
+    stub_request(:patch, "http://example.com/articles/1")
+      .with(headers: {content_type: "application/vnd.api+json", accept: "application/vnd.api+json"}, body: {
+          data: {
+            id: "1",
+            type: "articles",
+            attributes: {
+              title: "Modified title",
+            }
+          }
+        }.to_json)
+      .to_return(headers: {content_type: "application/vnd.api+json"}, body: {
+        errors: [
+          {
+            status: "400",
+            title: "Error"
+          }
+        ]
+      }.to_json)
+
+    exception = assert_raises JsonApiClient::Errors::RecordNotSaved do
+      article.update!(title: 'Modified title')
+    end
+    assert_equal "Record not saved", exception.message
+  end
+
   def test_can_update_found_record
     stub_simple_fetch
     articles = Article.find(1)