Skip to content

bug: External image fallback may not work reliably because it overwrites src without guarding #3607

@Aditya8369

Description

@Aditya8369

Description

On avatar , it sets:

(e.target as HTMLImageElement).src = 'https://github.com/github.png';

Steps to Reproduce

Block GitHub avatar images temporarily (browser devtools → Network block / or offline toggle).
Enter a username.
Observe console/network errors and whether the UI stabilizes.

Expected Behavior

Avatar fallback should be attempted once per broken image and then stop.
UI should remain stable (e.g., show placeholder) without repeated error loops.

Screenshots / Logs

No response

GitHub Username (If applicable)

No response

Environment

Chrome

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions