ci: simplify GitHub→Vercel pipeline to match Rez’s deployment flow

Author: JenyaL

.github/workflows/ci-deploy.yml

@@ -2,151 +2,110 @@ name: CI + Deploy (prebuilt)
 
 on:
   push:
-    branches: [ '**' ]       # prod only for main; others -> preview
+    branches: [ '**' ]
   pull_request:
-    branches: [ main ]       # PRs into main get preview link
+    branches: [ main ]
 
 permissions:
   contents: read
-  issues: write
-  pull-requests: write
   deployments: write
+  pull-requests: write
 
 env:
   VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}
   VERCEL_ORG:   ${{ secrets.VERCEL_ORG_ID }}
 
 jobs:
-  build_and_test:
+  build_and_deploy:
     runs-on: ubuntu-latest
     steps:
+      # Checkout repo
       - uses: actions/checkout@v4
+
+      # Setup Node.js + cache
       - uses: actions/setup-node@v4
         with:
           node-version: 18
           cache: 'npm'
-      - name: Install
-        run: npm ci || npm install
-      - name: Lint
-        run: npm run -s | grep -qE '(^| )lint( |:)' && npm run lint || echo "No lint script"
-      - name: Unit tests
-        run: npm run -s | grep -qE '(^| )test( |:)' && npm test --ci --passWithNoTests=false || echo "No test script"
-      - name: E2E tests (optional)
-        run: npm run -s | grep -qE '(^| )e2e( |:)' && npm run e2e || echo "No e2e script"
-      - name: App build
-        run: npm run build
-      - name: Build summary
-        run: echo "Build & tests passed ✅" >> "$GITHUB_STEP_SUMMARY"
 
-  deploy:
-    needs: build_and_test
-    if: ${{ success() }}
-    runs-on: ubuntu-latest
-    steps:
-      # PR conflict notice (comment)
-      - name: Warn if conflicts detected
-        if: ${{ github.event_name == 'pull_request' && github.event.pull_request.mergeable == false }}
-        uses: actions/github-script@v7
-        with:
-          script: |
-            await github.rest.issues.createComment({
-              ...context.repo,
-              issue_number: context.payload.pull_request.number,
-              body: "⚠️ **Merge conflict detected!**\nPlease resolve conflicts before merging."
-            })
+      # Install dependencies
+      - name: Install dependencies
+        run: npm ci || npm install
 
-      # PR conflict → fail checks (stops deploy)
-      - name: Fail if conflicts detected
-        if: ${{ github.event_name == 'pull_request' && github.event.pull_request.mergeable == false }}
-        run: |
-          echo "::error title=Merge conflict detected::Please resolve conflicts before merging."
-          exit 1
+      # Build project
+      - name: Build app
+        run: npm run build
 
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 18
-          cache: 'npm'
-      - name: Install Vercel CLI
+      # Install Vercel CLI
+      - name: Setup Vercel CLI
         run: npm i -g vercel@latest
 
-      - name: Decide target
-        id: tgt
+      # Define target (preview or production)
+      - name: Define target
+        id: target
         run: |
-          if [ "${{ github.event_name }}" = "pull_request" ]; then
-            echo "target=preview" >> $GITHUB_OUTPUT
-          elif [ "${{ github.ref_name }}" = "main" ]; then
-            echo "target=production" >> $GITHUB_OUTPUT
+          if [ "${{ github.ref_name }}" = "main" ]; then
+            echo "env=production" >> $GITHUB_OUTPUT
           else
-            echo "target=preview" >> $GITHUB_OUTPUT
+            echo "env=preview" >> $GITHUB_OUTPUT
           fi
 
-      - name: Pull Vercel project settings
+      # Pull project config and environment vars
+      - name: Pull Vercel settings
         run: |
           vercel pull --yes \
-            --environment "${{ steps.tgt.outputs.target }}" \
-            --token "${{ env.VERCEL_TOKEN }}" \
-            --scope "${{ env.VERCEL_ORG }}"
+            --environment="${{ steps.target.outputs.env }}" \
+            --token="${{ env.VERCEL_TOKEN }}" \
+            --scope="${{ env.VERCEL_ORG }}"
 
-      - name: Vercel prebuild
+      # Prebuild app (creates .vercel/output)
+      - name: Prebuild Vercel output
         run: |
           vercel build \
-            --token "${{ env.VERCEL_TOKEN }}" \
-            --scope "${{ env.VERCEL_ORG }}"
+            --token="${{ env.VERCEL_TOKEN }}" \
+            --scope="${{ env.VERCEL_ORG }}"
 
-      - name: Deploy (prebuilt)
+      # Deploy prebuilt build to Vercel
+      - name: Deploy prebuilt build
         id: deploy
-        env:
-          VC_TOKEN: ${{ env.VERCEL_TOKEN }}
-          VC_TEAM:  ${{ env.VERCEL_ORG }}
-          TARGET:   ${{ steps.tgt.outputs.target }}
         run: |
           set -e
-          ARGS=(deploy --yes --token "$VC_TOKEN" --scope "$VC_TEAM" --prebuilt)
-          [ "$TARGET" = "production" ] && ARGS+=(--prod) || true
-          URL="$(vercel "${ARGS[@]}")"
-          echo "url=$URL" >> "$GITHUB_OUTPUT"
-          echo "Deployed: $URL"
-
-      - name: Summary
-        run: |
-          echo "### Deployment" >> "$GITHUB_STEP_SUMMARY"
-          echo "- Target: **${{ steps.tgt.outputs.target }}**" >> "$GITHUB_STEP_SUMMARY"
-          if [ "${{ steps.tgt.outputs.target }}" = "production" ]; then
-            echo "- URL: (hidden for production)" >> "$GITHUB_STEP_SUMMARY"
+          if [ "${{ steps.target.outputs.env }}" = "production" ]; then
+            URL=$(vercel deploy --prebuilt --prod --yes --token "${{ env.VERCEL_TOKEN }}" --scope "${{ env.VERCEL_ORG }}")
           else
-            echo "- URL: ${{ steps.deploy.outputs.url }}" >> "$GITHUB_STEP_SUMMARY"
+            URL=$(vercel deploy --prebuilt --yes --token "${{ env.VERCEL_TOKEN }}" --scope "${{ env.VERCEL_ORG }}")
+          fi
+          echo "url=$URL" >> "$GITHUB_OUTPUT"
+          echo "✅ Deployed to $URL"
 
-      - name: Post Preview URL to PR
-        if: ${{ github.event_name == 'pull_request' && steps.deploy.outputs.url != '' }}
+      # Comment on PRs (preview link only)
+      - name: Comment Preview URL on PR
+        if: ${{ github.event_name == 'pull_request' }}
         uses: actions/github-script@v7
         with:
           script: |
             await github.rest.issues.createComment({
               ...context.repo,
               issue_number: context.payload.pull_request.number,
-              body: `✅ Preview ready: ${{ steps.deploy.outputs.url }}`
+              body: `✅ **Preview ready:** ${{ steps.deploy.outputs.url }}`
             })
 
-      - name: Link deployment to commit
-        if: ${{ github.event_name == 'push' && steps.deploy.outputs.url != '' }}
+      # Create GitHub Deployment card for main branch
+      - name: Create Deployment Card
+        if: ${{ github.ref_name == 'main' }}
         uses: actions/github-script@v7
         with:
           script: |
-            const isProd = (context.ref === 'refs/heads/main');
-            const envName = isProd ? 'production' : context.ref.replace('refs/heads/', '');
             const { data: dep } = await github.rest.repos.createDeployment({
               ...context.repo,
               ref: context.sha,
-              environment: envName,
+              environment: 'production',
               auto_merge: false,
               required_contexts: []
             });
-            const status = {
+            await github.rest.repos.createDeploymentStatus({
               ...context.repo,
               deployment_id: dep.id,
               state: 'success',
-              environment: envName
-            };
-            if (!isProd) status.environment_url = '${{ steps.deploy.outputs.url }}';
-            await github.rest.repos.createDeploymentStatus(status);
+              environment: 'production'
+            });