Proper check for successful connections

Author: jamezrin

src/main/java/com/jaimemartz/playerbalancer/commands/FallbackCommand.java

@@ -85,15 +85,7 @@ public void execute(CommandSender sender, String[] args) {
                             MessageUtils.send(player, ConfigEntries.INVALID_INPUT_MESSAGE.get());
                         }
                     } else {
-                        //TODO instead of checking if the sections are the same, we have to check if the section the player is
-                        //TODO currently going to contains the server the player is connected to
-                        //TODO this should be done in ConnectionIntent instead of here
-                        ServerSection current = plugin.getSectionManager().getByPlayer(player);
-                        if (current != target) {
-                            ConnectionIntent.simple(plugin, player, target);
-                        } else {
-                            MessageUtils.send(player, ConfigEntries.SAME_SECTION.get());
-                        }
+                        ConnectionIntent.simple(plugin, player, target);
                     }
                 }
             } catch (Exception e) {

src/main/java/com/jaimemartz/playerbalancer/connection/ConnectionIntent.java

@@ -9,6 +9,7 @@
 import net.md_5.bungee.api.Callback;
 import net.md_5.bungee.api.config.ServerInfo;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
+import net.md_5.bungee.api.connection.Server;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -30,7 +31,15 @@ public ConnectionIntent(PlayerBalancer plugin, ProxiedPlayer player, ProviderTyp
         );
 
         if (servers == section.getServers()) {
-            throw new IllegalStateException("The servers list parameter is the same object as the section servers list, this cannot happen");
+            throw new IllegalStateException("The servers list parameter is the same reference, this cannot happen");
+        }
+
+        Server current = player.getServer();
+        if (current != null) {
+            if (section.getServers().contains(current.getInfo())) {
+                MessageUtils.send(player, ConfigEntries.SAME_SECTION.get());
+                return;
+            }
         }
 
         if (section.getProvider() != ProviderType.NONE) {

src/main/java/com/jaimemartz/playerbalancer/connection/types/DirectionConnection.java

@@ -7,6 +7,7 @@
 import com.jaimemartz.playerbalancer.manager.PlayerLocker;
 import com.jaimemartz.playerbalancer.section.ServerSection;
 import com.jaimemartz.playerbalancer.utils.MessageUtils;
+import net.md_5.bungee.api.Callback;
 import net.md_5.bungee.api.config.ServerInfo;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
 import net.md_5.bungee.api.event.ServerConnectEvent;
@@ -64,12 +65,13 @@ public void onConnect(ServerConnectEvent event) {
             if (section != null) {
                 new ConnectionIntent(plugin, player, section) {
                     @Override
-                    public void connect(ServerInfo server) {
+                    public void connect(ServerInfo server, Callback<Boolean> callback) {
                         if (ConfigEntries.ASSIGN_TARGETS_ENABLED.get()) {
                             ServerAssignRegistry.assignTarget(player, section, server);
                         }
 
                         event.setTarget(server);
+                        callback.done(true, null);
                     }
                 };
             }

src/main/java/com/jaimemartz/playerbalancer/listener/ServerConnectListener.java

@@ -6,6 +6,7 @@
 import com.jaimemartz.playerbalancer.manager.PlayerLocker;
 import com.jaimemartz.playerbalancer.section.ServerSection;
 import com.jaimemartz.playerbalancer.utils.MessageUtils;
+import net.md_5.bungee.api.Callback;
 import net.md_5.bungee.api.chat.TextComponent;
 import net.md_5.bungee.api.config.ServerInfo;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
@@ -110,7 +111,7 @@ public void onKick(ServerKickEvent event) {
 
                 new ConnectionIntent(plugin, player, section, servers) {
                     @Override
-                    public void connect(ServerInfo server) {
+                    public void connect(ServerInfo server, Callback<Boolean> callback) {
                         PlayerLocker.lock(player);
                         MessageUtils.send(player, ConfigEntries.KICK_MESSAGE.get(),
                                 (str) -> str.replace("{from}", from.getName())
@@ -121,6 +122,7 @@ public void connect(ServerInfo server) {
                         plugin.getProxy().getScheduler().schedule(plugin, () -> {
                             PlayerLocker.unlock(player);
                         }, 5, TimeUnit.SECONDS);
+                        callback.done(true, null);
                     }
                 };
             }

src/main/java/com/jaimemartz/playerbalancer/listener/ServerKickListener.java

@@ -56,6 +56,7 @@ public void load() throws RuntimeException {
             section.postInit();
         });
 
+        //todo unify loading code with SectionManager
         if (ConfigEntries.SERVERS_UPDATE.get()) {
             updateTask = plugin.getProxy().getScheduler().schedule(plugin, () -> {
                 this.sections.forEach((name, section) -> {

src/main/java/com/jaimemartz/playerbalancer/section/SectionManager.java

@@ -39,7 +39,7 @@
  *   Use the static "sort" method from the java.util.Collections class:
  *   Collections.sort(your list, new AlphanumComparator());
  */
-public class AlphanumComparator implements Comparator
+public final class AlphanumComparator implements Comparator
 {
     private final boolean isDigit(char ch)
     {

src/main/java/com/jaimemartz/playerbalancer/utils/AlphanumComparator.java

@@ -1,6 +1,6 @@
 package com.jaimemartz.playerbalancer.utils;
 
-public class DigitUtils {
+public final class DigitUtils {
     public static int getDigits(String string, int digits) {
         StringBuilder builder = new StringBuilder();
 

src/main/java/com/jaimemartz/playerbalancer/utils/DigitUtils.java

@@ -7,7 +7,7 @@
 import java.util.HashMap;
 import java.util.Map;
 
-public class FixedAdapter extends AdapterWrapper {
+public final class FixedAdapter extends AdapterWrapper {
     private static final Map<String, ServerInfo> fakeServers = new HashMap<>();
 
     static {

src/main/java/com/jaimemartz/playerbalancer/utils/FixedAdapter.java

@@ -15,7 +15,7 @@
 import java.util.List;
 
 @Data
-public class GuestPaste {
+public final class GuestPaste {
     private final String key;
     private final String code;