fix(jans-cedarling): early error returns in build_entity_attrs cause test failures

[dagregi]

Describe the bug
Adding early error returns in build_entity_attrs_with_shape function causes multiple tests to fail.

To Reproduce
Steps to reproduce the behavior:

1. Add early return in jans-cedarling/cedarling/src/entity_builder/build_entity_attrs.rs and update jans-cedarling/cedarling/src/entity_builder/error.rs
2. Run the tests with cargo test -p cedarling
3. Multiple tests that previously passed will now fail due to early error returns

To check add the below code:

• In build_entity_attrs.rs line 153 add:

    if !errs.is_empty() {
        return Err(BuildAttrsErrorVec::from(errs));
    }

• In error.rs add:

impl From<Vec<BuildAttrsError>> for BuildAttrsErrorVec {
    fn from(errs: Vec<BuildAttrsError>) -> Self {
        Self(errs)
    }
}

Expected behavior
Tests should continue to pass.

Additional context

The issue appears to be that the new early error return changes the flow of error handling. The existing code doesn't return errors so maybe this is wanted by design, and adding the early return may be redundant or interfering with the existing error handling logic.

[coderabbitai]

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

• Create Plan

Examples

• Example 1
• Example 2

---

🔗 Related PRs

#12544 - fix(jans-cedarling): Fix retrieving resource entity from default entities [merged]
#12964 - chore(jans-cedarling): Run clippy over unit tests [merged]
#13024 - fix(jans-cedarling): fix entities mapping for not required entities [merged]

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[haileyesus2433]

@dagregi am confused apply the current changes from where could u please be specific, like if its another branch a link to the branch if its a pr a link to the pr would be nice, because am confused 😕

[dagregi]

@dagregi am confused apply the current changes from where could u please be specific, like if its another branch a link to the branch if its a pr a link to the pr would be nice, because am confused 😕

The issue is when you add a return, the code mentioned above, in build_entity_attrs_with_shape function found in jans-cedarling/cedarling/src/entity_builder/build_entity_attrs.rs some tests fail

[haileyesus2433]

@dagregi am confused apply the current changes from where could u please be specific, like if its another branch a link to the branch if its a pr a link to the pr would be nice, because am confused 😕

The issue is when you add a return, the code mentioned above, in build_entity_attrs_with_shape function found in jans-cedarling/cedarling/src/entity_builder/build_entity_attrs.rs some tests fail

ok but did u discover this bug when working on the optimization or is there another issue related to this?

[dagregi]

I found it when working on #12866 and even tried it on the main branch and the same failure happens also I haven't found any issues related to this

[pradhankukiran]

I reproduced this locally, and the early return does cause real regressions.

From what I found, the problem is that build_entity_attrs_with_shape runs before some callers finish assembling the final attrs. In particular build_principal_entity can merge attrs from multiple token sources later and build_multi_issuer_entity adds reserved attrs like iss, jti, exp, token_type, and validated_at after extraction.

So returning Err directly from build_entity_attrs_with_shape looks too early. The fix likely needs to validate after final attr assembly, not during partial extraction.

If that direction makes sense, I can work on a PR with regression tests.