From 5176767ed60f417c1ee252d4c29fb2fe19b21c58 Mon Sep 17 00:00:00 2001 From: JSONbored <49853598+JSONbored@users.noreply.github.com> Date: Sun, 12 Jul 2026 06:37:12 -0700 Subject: [PATCH] docs(engine): fix stale comment claiming review.linkedIssueSatisfaction is unconsumed True when written (#4069, 2026-07-07), invalidated three days later by #4149 (src/signals/focus-manifest.ts's resolveEffectiveSettings), which added a fallback-alias: when gate.linkedIssueSatisfaction is unset, review.linkedIssueSatisfaction IS folded in and feeds the real merge/close decision. None of the 7 subsequent commits touching this file corrected the comment. src/types.ts already carries the correct, current description. Comment-only, no behavior change. Refs #5284 --- packages/gittensory-engine/src/focus-manifest.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/gittensory-engine/src/focus-manifest.ts b/packages/gittensory-engine/src/focus-manifest.ts index 38677a31d..4b49dd486 100644 --- a/packages/gittensory-engine/src/focus-manifest.ts +++ b/packages/gittensory-engine/src/focus-manifest.ts @@ -133,8 +133,11 @@ export type FocusManifestGateConfig = { * "unaddressed" verdict become a hard blocker. DB-backed (dashboard-settable too); this overrides the * stored value -- mirrors `aiReviewMode` above, not the config-as-code-only `unlinkedIssueGuardrail` * pattern. Distinct from the pre-existing, config-as-code-only `review.linkedIssueSatisfaction` (#2173, - * below) -- that field is parsed but not yet consumed by any decision path; this `gate:` field is the one - * the merge/close decision actually reads. */ + * below) in type and storage -- but as of #4149 (`src/signals/focus-manifest.ts`'s + * `resolveEffectiveSettings`, ~line 611-618) `review.linkedIssueSatisfaction` IS folded in as a + * fallback alias whenever this `gate:` field is unset, so setting either spelling drives the same real + * merge/close decision. See `src/types.ts`'s `linkedIssueSatisfactionGateMode` doc for the authoritative + * cross-reference. */ linkedIssueSatisfaction: GateRuleMode | null; dryRun: boolean | null; firstTimeContributorGrace: boolean | null;