Context
packages/gittensory-engine/src/focus-manifest.ts:135-137's doc comment on gate.linkedIssueSatisfaction says: "that field [review.linkedIssueSatisfaction] is parsed but not yet consumed by any decision path." This was true when written (commit 3356fc605, #4069, 2026-07-07) but was invalidated three days later by commit dba049793/02fd0d0b2 (#4811, "#4149", 2026-07-10), which added a fallback-alias in src/signals/focus-manifest.ts:611-618: when gate.linkedIssueSatisfaction is unset, review.linkedIssueSatisfaction IS now folded in and feeds the real gate/merge decision. None of the 7 subsequent commits touching this file since 2026-07-10 corrected the comment. src/types.ts:818-829 already carries the correct, current description ("setting either spelling has the same real effect").
Comment-only inconsistency — actual runtime behavior is correct and already well-documented elsewhere. Risk is conditional/future: a self-hoster reading only the engine-package source could be misled that the review: spelling is dead, or a future refactor could "clean up" the #4149 fallback trusting this stale comment as rationale.
Requirements
- Comment-only fix, no test required.
Deliverables
Expected Outcome
The engine-package source no longer contradicts the actual, correct behavior already documented in src/types.ts.
Links & Resources
- Evidence:
packages/gittensory-engine/src/focus-manifest.ts:130-138 vs :653-657; src/signals/focus-manifest.ts:611-618; src/types.ts:818-829; scripts/check-docs-drift.mjs:249 (alias manifest already tracks this correctly)
Part of #5270 (roadmap epic).
Context
packages/gittensory-engine/src/focus-manifest.ts:135-137's doc comment ongate.linkedIssueSatisfactionsays: "that field [review.linkedIssueSatisfaction] is parsed but not yet consumed by any decision path." This was true when written (commit3356fc605, #4069, 2026-07-07) but was invalidated three days later by commitdba049793/02fd0d0b2(#4811, "#4149", 2026-07-10), which added a fallback-alias insrc/signals/focus-manifest.ts:611-618: whengate.linkedIssueSatisfactionis unset,review.linkedIssueSatisfactionIS now folded in and feeds the real gate/merge decision. None of the 7 subsequent commits touching this file since 2026-07-10 corrected the comment.src/types.ts:818-829already carries the correct, current description ("setting either spelling has the same real effect").Comment-only inconsistency — actual runtime behavior is correct and already well-documented elsewhere. Risk is conditional/future: a self-hoster reading only the engine-package source could be misled that the
review:spelling is dead, or a future refactor could "clean up" the #4149 fallback trusting this stale comment as rationale.Requirements
Deliverables
focus-manifest.ts:135-137with an accurate cross-reference: distinct fromreview.linkedIssueSatisfactionin type/storage, but as of docs(review): resolve the review.linked_issue_satisfaction / gate.linkedIssueSatisfaction phantom-field confusion #4149 (src/signals/focus-manifest.ts'sresolveEffectiveSettings, ~line 611-618) it IS folded in as a fallback alias whenever thegate:field is unset, so setting either spelling drives the same real merge/close decision. Cross-referencesrc/types.ts'slinkedIssueSatisfactionGateModedoc.Expected Outcome
The engine-package source no longer contradicts the actual, correct behavior already documented in
src/types.ts.Links & Resources
packages/gittensory-engine/src/focus-manifest.ts:130-138vs:653-657;src/signals/focus-manifest.ts:611-618;src/types.ts:818-829;scripts/check-docs-drift.mjs:249(alias manifest already tracks this correctly)Part of #5270 (roadmap epic).