Use to_json for hash_cache_field to get millisecond precision for times

Author: lgebhardt

lib/jsonapi/basic_resource.rb

@@ -1019,7 +1019,8 @@ def attribute_caching_context(_context)
 
       # Generate a hashcode from the value to be used as part of the cache lookup
       def hash_cache_field(value)
-        Digest::MD5.hexdigest(value.to_s)
+        # using to_json to convert to strings. This has the advantage of using milliseconds for times
+        Digest::MD5.hexdigest(value.to_json)
       end
 
       def _model_class

test/fixtures/posts.yml

@@ -3,6 +3,8 @@ post_1:
   title: New post
   body: A body!!!
   author_id: 1001
+  created_at: 2020-01-01 14:15:16 UTC
+  updated_at: 2020-01-15 14:15:12 UTC
 
 post_2:
   id: 2

test/unit/resource/resource_test.rb

@@ -95,7 +95,7 @@ class PostWithReadonlyAttributesResource < JSONAPI::Resource
 
 class ResourceTest < ActiveSupport::TestCase
   def setup
-    @post = Post.first
+    @post = posts(:post_1)
   end
 
   def test_model_name
@@ -126,6 +126,33 @@ def test_resource_for_resource_does_not_exist_at_root
     end
   end
 
+  def test_cache_ids_are_consistent_from_run_to_run
+    assert_equal '2020-01-15 14:15:12 UTC', @post.updated_at.to_s
+
+    post_resource = PostResource.new(@post, {})
+    assert_equal [@post.id, 'b740b00b69a15835ea82d7e6d093a59e'], post_resource.cache_id
+  end
+
+  def test_cache_ids_change_when_cache_field_is_changed
+    assert_equal '2020-01-15 14:15:12 UTC', @post.updated_at.to_s
+
+    post_resource = PostResource.new(@post, {})
+    assert_equal [@post.id, 'b740b00b69a15835ea82d7e6d093a59e'], post_resource.cache_id
+
+    assert @post.touch
+    refute_equal [@post.id, 'b740b00b69a15835ea82d7e6d093a59e'], post_resource.cache_id
+  end
+
+  def test_date_based_cache_ids_change_with_milliseconds_if_hash_cache_field_uses_to_json
+    assert_equal '2020-01-15 14:15:12 UTC', @post.updated_at.to_s
+
+    post_resource = PostResource.new(@post, {})
+    assert_equal [@post.id, 'b740b00b69a15835ea82d7e6d093a59e'], post_resource.cache_id
+
+    @post.updated_at = @post.updated_at + 0.222
+    refute_equal [@post.id, 'b740b00b69a15835ea82d7e6d093a59e'], post_resource.cache_id
+  end
+
   def test_resource_for_with_underscored_namespaced_paths
     assert_equal(JSONAPI::Resource.resource_klass_for('my_module/related'), MyModule::RelatedResource)
     assert_equal(PostResource.resource_klass_for('my_module/related'), MyModule::RelatedResource)