No OnChange event on node selection

[oti-ud]

With the master branch up-to-date, there is no OnChange event when node selection changes. Reverting to v8.3 restores correct behavior.

[joachimmarder]

Can be repro-ed using the Advanced sample proejct on page "Visibility Demo", the OnChnage event is never fired here.

[joachimmarder]

@seems this bug was introduced with pull request #1337

@chuacw : Can you please have a look?

[chuacw]

@joachimmarder I'm confused on what to do because I see you've already committed a fix.

[joachimmarder]

I'm confused on what to do because I see you've already committed a fix.

That wasn't a fix. I just reverted a commit locally that was related to the OnChnage event to see of that fixes the reported issue. I pushed this reverted commit to GitHub by accident. I just reverted the revert - sorry!

[chuacw]

I am looking into this.
@oti-ud @joachimmarder can you please provide repro steps clearly?

[oti-ud]

@chuacw it should be reproducible with any simple VST demo code: just assign an OnChange handler to the VST control. The OnChange should fire when the node selection changes; it currently does not. I didn't investigate which commit introduced the issue, but going back to v8.3 restores the correct behavior.

[joachimmarder]

can you please provide repro steps clearly?

@chuacw sure:

• Open the projects Advanced.dproj
• Open the form VisibilityDemo.dfm
• Select the control VST2
• Double click the OnChnageevent.
• Add thee code ShowMessage('VST2.OnChnage');
• Press F9
• Go to the 4th page
• Change the selection in the control on the bottm left

Expected

A dialog pops up

Actual

Nothing happens

[chuacw]

Thanks for the steps, @joachimmarder !
I've just created a PR for fixing this.

[joachimmarder]

@oti-ud: Could you please check if the latest source code fixes your problem?