🧪 Added more tests

Author: joaodordio

tests/unit-tests/EmbeddedManagerTests.swift

@@ -109,6 +109,33 @@ final class EmbeddedManagerTests: XCTestCase {
 
         wait(for: [syncMessagesExpectation, delegateExpectation, syncSuccessExpectation], timeout: 2)
     }
+
+    func testSyncMessagesWithPlacementIdsDoesNotClearOtherPlacements() {
+        let mockApiClient = MockApiClient()
+        mockApiClient.populateMessages([
+            1: [IterableEmbeddedMessage(messageId: "1a", placementId: 1)],
+            2: [IterableEmbeddedMessage(messageId: "2a", placementId: 2)],
+        ])
+        
+        let manager = IterableEmbeddedManager(apiClient: mockApiClient,
+                                              urlDelegate: nil,
+                                              customActionDelegate: nil,
+                                              urlOpener: MockUrlOpener(),
+                                              allowedProtocols: [],
+                                              enableEmbeddedMessaging: true)
+        
+        manager.syncMessages { }
+        XCTAssertEqual(manager.getMessages(for: 2).map { $0.metadata.messageId }, ["2a"])
+        
+        // Update only placement 1 on the "server", then request only that placement.
+        mockApiClient.populateMessages([
+            1: [IterableEmbeddedMessage(messageId: "1b", placementId: 1)],
+        ])
+        manager.syncMessages(placementIds: [1]) { }
+        
+        XCTAssertEqual(manager.getMessages(for: 1).map { $0.metadata.messageId }, ["1b"])
+        XCTAssertEqual(manager.getMessages(for: 2).map { $0.metadata.messageId }, ["2a"])
+    }
 
     func testManagerReset() {
         let syncMessagesExpectation = expectation(description: "syncMessages should complete")

tests/unit-tests/RequestCreatorTests.swift

@@ -177,6 +177,51 @@ class RequestCreatorTests: XCTestCase {
         XCTAssertEqual(args[JsonKey.InApp.count], inAppMessageRequestCount.stringValue)
         XCTAssertEqual(args[JsonKey.systemVersion], UIDevice.current.systemVersion)
     }
+
+    func testGetEmbeddedMessagesRequestFailure() {
+        let auth = Auth(userId: nil, email: nil, authToken: nil, userIdUnknownUser: nil)
+        let requestCreator = RequestCreator(auth: auth, deviceMetadata: deviceMetadata)
+        
+        let failingRequest = requestCreator.createGetEmbeddedMessagesRequest(placementIds: nil)
+        
+        if let _ = try? failingRequest.get() {
+            XCTFail("request succeeded despite userId and email being nil")
+        }
+    }
+    
+    func testGetEmbeddedMessagesRequest() {
+        let request = createRequestCreator().createGetEmbeddedMessagesRequest(placementIds: nil)
+        let urlRequest = convertToUrlRequest(request)
+        
+        TestUtils.validateHeader(urlRequest, apiKey)
+        TestUtils.validate(request: urlRequest, requestType: .get, apiEndPoint: Endpoint.api, path: Const.Path.getEmbeddedMessages)
+        
+        guard case let .success(.get(getRequest)) = request, let args = getRequest.args else {
+            XCTFail("could not unwrap to a get request and its arguments")
+            return
+        }
+        
+        XCTAssertEqual(args[JsonKey.email], auth.email)
+        XCTAssertEqual(args[JsonKey.Embedded.packageName], Bundle.main.appPackageName)
+        XCTAssertEqual(args[JsonKey.systemVersion], UIDevice.current.systemVersion)
+        XCTAssertNil(args[JsonKey.Embedded.placementIds])
+    }
+    
+    func testGetEmbeddedMessagesRequestWithPlacementIds() {
+        let request = createRequestCreator().createGetEmbeddedMessagesRequest(placementIds: [1, 2, 3])
+        let urlRequest = convertToUrlRequest(request)
+        
+        TestUtils.validateHeader(urlRequest, apiKey)
+        TestUtils.validate(request: urlRequest, requestType: .get, apiEndPoint: Endpoint.api, path: Const.Path.getEmbeddedMessages)
+        
+        guard case let .success(.get(getRequest)) = request, let args = getRequest.args else {
+            XCTFail("could not unwrap to a get request and its arguments")
+            return
+        }
+        
+        XCTAssertEqual(args[JsonKey.email], auth.email)
+        XCTAssertEqual(args[JsonKey.Embedded.placementIds], "1,2,3")
+    }
 
     func testTrackEventRequest() {
         let eventName = "dsfsdf"