coderabbitai facturx10x.xml

[nielsdrost7]

In the Facturv10Xml.php we only define the SpecifiedTradePaymentTerms:ram:Descriptions with a concatenation of sting and due date.

InvoicePlane-e-invoices/application/libraries/XMLtemplates/Facturxv10Xml.php

Line 141 in ad5e8f7

$node->appendChild($this->doc->createElement('ram:Description', $PaymentTerms));

In this Schema, we can also define the date as date string. I think we should add this also

<ram:SpecifiedTradePaymentTerms>
  <ram:Description>Fällig am 15.05.2025</ram:Description>
  <ram:DueDateDateTime>
    <udt:DateTimeString format="102">20250815</udt:DateTimeString>
  </ram:DueDateDateTime>
</ram:SpecifiedTradePaymentTerms>

[nielsdrost7]

@coderabbitai make plan

[coderabbitai]

Coding Plan

Approach

Add a structured ram:DueDateDateTime element with udt:DateTimeString format="102" to the SpecifiedTradePaymentTerms section in the Factur-X 1.0 XML template, providing machine-readable date information alongside the existing human-readable description.

Observations

The project is an e-invoicing library with XML templates in application/libraries/XMLtemplates/. The Facturxv10Xml.php file extends BaseXml.php and generates Factur-X 1.0/ZUGFeRD 2.3 compliant XML using PHP's DOMDocument API.

A reusable dateElement() helper method already exists (lines 106-111) that creates udt:DateTimeString elements with format="102" attribute in YYYYMMDD format. This same pattern is used throughout the file for other date fields (IssueDateTime, OccurrenceDateTime, StartDateTime, EndDateTime). The formattedDate() method in BaseXml.php handles the date string conversion from 'Y-m-d' to 'Ymd' format.

Implementation Steps

Add Structured Due Date Element to Payment Terms

Enhance the payment terms XML generation to include both human-readable and machine-readable due date information, following the Factur-X schema specification where format="102" indicates YYYYMMDD format.

Add DueDateDateTime Element to xmlSpecifiedTradePaymentTerms Method

Modify the xmlSpecifiedTradePaymentTerms() method in application/libraries/XMLtemplates/Facturxv10Xml.php to append a structured due date element after the existing Description element.

• Locate the xmlSpecifiedTradePaymentTerms() method (lines 131-143) which currently creates only the ram:Description element
• After appending the Description element to the node, create a new ram:DueDateDateTime container element
• Reuse the existing dateElement() helper method (lines 106-111) to generate the udt:DateTimeString child element with format="102" attribute
• Pass $this->invoice->invoice_date_due to the dateElement helper, which is already used in this method for the Description text
• Append the DueDateDateTime element to the SpecifiedTradePaymentTerms node, resulting in the XML structure specified in the ticket

🤖 Prompt for AI agents

Enhance the payment terms XML generation to include a structured due date
element alongside the existing human-readable description.

In `application/libraries/XMLtemplates/Facturxv10Xml.php`, modify the
`xmlSpecifiedTradePaymentTerms()` method:
- After appending the existing Description element, create a new
`ram:DueDateDateTime` container element
- Use the existing `dateElement()` helper method to generate a
`udt:DateTimeString` child element with `format="102"` attribute
- Pass `$this->invoice->invoice_date_due` to the dateElement helper
- Append the DueDateDateTime element to the SpecifiedTradePaymentTerms node

---

🚀 Next Steps

🤖 All AI agent prompts combined

Enhance the payment terms XML generation to include a structured due date
element alongside the existing human-readable description.

In `application/libraries/XMLtemplates/Facturxv10Xml.php`, modify the
`xmlSpecifiedTradePaymentTerms()` method:
- After appending the existing Description element, create a new
`ram:DueDateDateTime` container element
- Use the existing `dateElement()` helper method to generate a
`udt:DateTimeString` child element with `format="102"` attribute
- Pass `$this->invoice->invoice_date_due` to the dateElement helper
- Append the DueDateDateTime element to the SpecifiedTradePaymentTerms node

💡 Iterate on the plan with: @coderabbitai <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For assumption 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!