lirc: Add support for client pings.

Currently, LIRC only supports server pings (server pings us,
we pong back), but clients can send pings too and get pongs
back (typically to measure lag). Add support for this.

PONG is intentionally being added right after PING in the enum,
so this does NOT preserve ABI across versions.

Author: InterLinked1

.github/workflows/main.yml

@@ -2,7 +2,7 @@ name: CI
 
 on:
   push:
-    branches: [ master ]
+    branches: [ master, dev ]
   pull_request:
     branches: [ master ]
 

irc.c

@@ -870,6 +870,11 @@ int irc_client_notice(struct irc_client *client, const char *channel, const char
 	return irc_send(client, "NOTICE %s :%s", channel, msg);
 }
 
+int irc_client_ping(struct irc_client *client, const char *pingmsg)
+{
+	return irc_send(client, "PING :%s", pingmsg);
+}
+
 int irc_client_pong(struct irc_client *client, struct irc_msg *msg)
 {
 	/* Reply with the same data that it sent us (some servers may actually require that) */
@@ -1035,6 +1040,8 @@ int irc_parse_msg_type(struct irc_msg *msg)
 		}
 	} else if (!strcasecmp(c, "PING")) {
 		msg->type = IRC_CMD_PING;
+	} else if (!strcasecmp(c, "PONG")) {
+		msg->type = IRC_CMD_PONG;
 	} else if (!strcasecmp(c, "JOIN")) {
 		msg->type = IRC_CMD_JOIN;
 		PARSE_CHANNEL();

irc.h

@@ -11,8 +11,8 @@
  */
 
 #define LIRC_VERSION_MAJOR 1
-#define LIRC_VERSION_MINOR 0
-#define LIRC_VERSION_PATCH 1
+#define LIRC_VERSION_MINOR 1
+#define LIRC_VERSION_PATCH 0
 
 /*! \brief Maximum length of an IRC message, including trailing CR LF */
 #define IRC_MAX_MSG_LEN 512
@@ -29,6 +29,7 @@ enum irc_msg_type {
 	IRC_CMD_PRIVMSG,
 	IRC_CMD_NOTICE,		/*!< Same as PRIVMSG, but should never be acknowledged, to prevent loops */
 	IRC_CMD_PING,
+	IRC_CMD_PONG,
 	IRC_CMD_JOIN,
 	IRC_CMD_PART,
 	IRC_CMD_QUIT,
@@ -204,6 +205,18 @@ int irc_client_msg(struct irc_client *client, const char *channel, const char *m
  */
 int irc_client_notice(struct irc_client *client, const char *channel, const char *msg);
 
+/*!
+ * \brief Send a PING message to the server
+ * \param client
+ * \param pingmsg A user-provided message that will be echoed back in the PONG reply
+ * \retval 0 on success, -1 on failure
+ * \note Servers are responsible for pinging clients, so normally, clients don't
+ *       need to initiate pings to the server. However, this can be useful
+ *       if the client wants to measure lag (by processing IRC_CMD_PONG).
+ *       Note the PONG response has format '<hostname> :<ping message>'
+ */
+int irc_client_ping(struct irc_client *client, const char *pingmsg);
+
 /*!
  * \brief Send a PONG reply to a PING message
  * \param client