Blocks placed during /plot delete confirmation remain after plot is deleted

[florianreuth]

Server Implementation

Paper

Server Version

1.21.3

Describe the bug

When deleting a plot, any blocks that are placed during the /p confirm phase remain on the plot even after it is deleted or becomes unclaimed.
These blocks are not removed together with the plot deletion process.

To Reproduce

1. Initiate a plot deletion (/plot delete).
2. While waiting for the confirmation, place several blocks on the plot.
3. Execute /plot confirm.
4. The plot is deleted / unclaimed, but the blocks placed during the confirmation phase remain instead of being removed.

Expected behaviour

All blocks placed on the plot (including those placed during the deletion confirmation phase) should be removed when the plot is deleted or unclaimed.

Screenshots / Videos

Unbenanntes.Video.Mit.Clipchamp.erstellt.16.mp4

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/04b06c6d51d3420bab74485da6499af0

PlotSquared Version

PlotSquared version 7.5.10-SNAPSHOT

Checklist

• I have included a Plot debugpaste.
• I am using the newest build from https://www.spigotmc.org/resources/77506/ and the issue still persists.

Anything else?

No response

[NotMyFault]

Unsure whether that is fixable or considered a bug.

[ByteExceptionM]

Unsure whether that is fixable or considered a bug.

I think it's definitely a bug when a plot in the plot world that should be deleted still has blocks. When you're confirming or starting to delete a plot, set temporary metadata to the plot, and if it's set, cancel the BlockPlaceEvent and BlockBreakEvent (I assume that this will work the same way here). That should be the simplest fix.

[NotMyFault]

Unsure whether that is fixable or considered a bug.

I think it's definitely a bug when a plot in the plot world that should be deleted still has blocks. When you're confirming or starting to delete a plot, set temporary metadata to the plot, and if it's set, cancel the BlockPlaceEvent and BlockBreakEvent (I assume that this will work the same way here). That should be the simplest fix.

Thanks for sharing your analysis! Are you interested in submitting a PR to fix the issue?

[ByteExceptionM]

Unsure whether that is fixable or considered a bug.

I think it's definitely a bug when a plot in the plot world that should be deleted still has blocks. When you're confirming or starting to delete a plot, set temporary metadata to the plot, and if it's set, cancel the BlockPlaceEvent and BlockBreakEvent (I assume that this will work the same way here). That should be the simplest fix.

Thanks for sharing your analysis! Are you interested in submitting a PR to fix the issue?

Sure! @FlorianMichael takes care of it.

[florianreuth]

I've sent a pull request: #4818