Skip to content

Commit f29d55d

Browse files
committed
Simplify ClickHouse startup - use default configuration
Remove custom --path option which causes 'Unknown option specified' error. ClickHouse pre-built binary expects to run with default configuration. Changes: - Run simply: ./clickhouse server - Let ClickHouse use its default data directory - Added 5s initial sleep to allow server to initialize - Removed invalid --path, --http_port, --tcp_port options ClickHouse listens on default ports (9000 for TCP, 8123 for HTTP) which matches what our tests expect.
1 parent a675ffe commit f29d55d

1 file changed

Lines changed: 6 additions & 14 deletions

File tree

.github/workflows/precompile.yml

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: Precompile NIFs
33
on:
44
push:
55
tags:
6-
- 'v*'
6+
- "v*"
77

88
jobs:
99
# Build and test on x86_64 Linux, cross-compile for other Linux architectures
@@ -162,19 +162,15 @@ jobs:
162162
163163
- name: Start ClickHouse server
164164
run: |
165-
mkdir -p ./clickhouse_data
166-
./clickhouse server \
167-
--path ./clickhouse_data \
168-
--http_port 8123 \
169-
--tcp_port 9000 \
170-
> ./clickhouse_server.log 2>&1 &
165+
./clickhouse server > ./clickhouse_server.log 2>&1 &
171166
echo $! > ./clickhouse_server.pid
172167
echo "ClickHouse server started with PID $(cat ./clickhouse_server.pid)"
168+
sleep 5
173169
174170
- name: Wait for ClickHouse
175171
run: |
176172
echo "Waiting for ClickHouse to start..."
177-
for i in {1..60}; do
173+
for i in {1..15}; do
178174
if ./clickhouse client --query "SELECT 1" 2>/dev/null; then
179175
echo "ClickHouse is ready!"
180176
./clickhouse client --query "SELECT version()"
@@ -239,14 +235,10 @@ jobs:
239235
240236
- name: Start ClickHouse server
241237
run: |
242-
mkdir -p ./clickhouse_data
243-
./clickhouse server \
244-
--path ./clickhouse_data \
245-
--http_port 8123 \
246-
--tcp_port 9000 \
247-
> ./clickhouse_server.log 2>&1 &
238+
./clickhouse server > ./clickhouse_server.log 2>&1 &
248239
echo $! > ./clickhouse_server.pid
249240
echo "ClickHouse server started with PID $(cat ./clickhouse_server.pid)"
241+
sleep 5
250242
251243
- name: Wait for ClickHouse
252244
run: |

0 commit comments

Comments
 (0)