From e5e975514ba7f394d41454aebb8e47c3cfe937ed Mon Sep 17 00:00:00 2001 From: "Hans J. Johnson" Date: Wed, 15 Apr 2026 11:13:39 -0500 Subject: [PATCH] COMP: IO modules publicly depend on ImageIOBase DCMTK, GE, LSM, and PhilipsREC have public headers that #include itkImageIOBase.h or inherit from ImageIOBase, making ITKIOImageBase a genuine public dependency. Move it from PRIVATE_DEPENDS to DEPENDS so downstream consumers receive the transitive include paths and link targets. Follows the same pattern as the VTK fix in PR #5850. --- Modules/IO/DCMTK/itk-module.cmake | 3 ++- Modules/IO/GE/itk-module.cmake | 1 - Modules/IO/LSM/itk-module.cmake | 2 +- Modules/IO/PhilipsREC/itk-module.cmake | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Modules/IO/DCMTK/itk-module.cmake b/Modules/IO/DCMTK/itk-module.cmake index 7e65d3e3b67..2ab82142b8a 100644 --- a/Modules/IO/DCMTK/itk-module.cmake +++ b/Modules/IO/DCMTK/itk-module.cmake @@ -7,9 +7,10 @@ href=\"https://dicom.offis.de/dcmtk/\">DCMTK DCMTK is a collection of librar itk_module( ITKIODCMTK ENABLE_SHARED + DEPENDS + ITKIOImageBase PRIVATE_DEPENDS ITKDCMTK - ITKIOImageBase TEST_DEPENDS ITKTestKernel ITKImageIntensity diff --git a/Modules/IO/GE/itk-module.cmake b/Modules/IO/GE/itk-module.cmake index 766fc450e1e..36515f3d463 100644 --- a/Modules/IO/GE/itk-module.cmake +++ b/Modules/IO/GE/itk-module.cmake @@ -10,7 +10,6 @@ itk_module( ENABLE_SHARED DEPENDS ITKIOIPL - PRIVATE_DEPENDS ITKIOImageBase TEST_DEPENDS ITKTestKernel diff --git a/Modules/IO/LSM/itk-module.cmake b/Modules/IO/LSM/itk-module.cmake index 50ad513f153..6a2ac86e5e3 100644 --- a/Modules/IO/LSM/itk-module.cmake +++ b/Modules/IO/LSM/itk-module.cmake @@ -10,9 +10,9 @@ itk_module( ITKIOLSM DEPENDS ITKIOTIFF + ITKIOImageBase ENABLE_SHARED PRIVATE_DEPENDS - ITKIOImageBase ITKTIFF TEST_DEPENDS ITKTestKernel diff --git a/Modules/IO/PhilipsREC/itk-module.cmake b/Modules/IO/PhilipsREC/itk-module.cmake index a21801e11bd..6d06e26ef17 100644 --- a/Modules/IO/PhilipsREC/itk-module.cmake +++ b/Modules/IO/PhilipsREC/itk-module.cmake @@ -7,8 +7,9 @@ REC/PAR image files." itk_module( ITKIOPhilipsREC ENABLE_SHARED - PRIVATE_DEPENDS + DEPENDS ITKIOImageBase + PRIVATE_DEPENDS ITKZLIB TEST_DEPENDS ITKTestKernel