explicit the fact that mounting a filesystem may fail

Author: Baptouuuu

CHANGELOG.md

@@ -16,6 +16,7 @@
 - `Innmind\OperatingSystem\Config::withHttpHeartbeat()` period is now expressed with a `Innmind\TimeContinuum\Period`
 - `Innmind\OperatingSystem\CurrentProcess::id()` now returns an `Innmind\Immutable\Attempt`
 - `Innmind\OperatingSystem\CurrentProcess::halt()` now returns `Innmind\Immutable\Attempt<Innmind\Immutable\SideEffect>`
+- `Innmind\OperatingSystem\Filesystem::mount()` now returns an `Innmind\Immutable\Attempt`
 - `Innmind\OperatingSystem\Filesystem::temporary()` now returns an `Innmind\Immutable\Attempt`
 - `Innmind\OperatingSystem\Ports::open()` now returns an `Innmind\Immutable\Attempt`
 - `Innmind\OperatingSystem\Remote::socket()` now returns an `Innmind\Immutable\Attempt`

src/Filesystem.php

@@ -18,7 +18,10 @@
 
 interface Filesystem
 {
-    public function mount(Path $path): Adapter;
+    /**
+     * @return Attempt<Adapter>
+     */
+    public function mount(Path $path): Attempt;
     public function contains(Path $path): bool;
 
     /**

src/Filesystem/Generic.php

@@ -48,28 +48,30 @@ public static function of(Processes $processes, Config $config): self
     }
 
     #[\Override]
-    public function mount(Path $path): Adapter
+    public function mount(Path $path): Attempt
     {
         /**
          * @var Adapter $adapter
          * @var string $mounted
          */
         foreach ($this->mounted as $adapter => $mounted) {
             if ($path->toString() === $mounted) {
-                return $adapter;
+                return Attempt::result($adapter);
             }
         }
 
-        $adapter = Adapter\Filesystem::mount(
-            $path,
-            $this->config->io(),
-        )
-            ->withCaseSensitivity(
-                $this->config->filesystemCaseSensitivity(),
-            );
-        $this->mounted[$adapter] = $path->toString();
-
-        return $adapter;
+        return Attempt::of(function() use ($path) {
+            $adapter = Adapter\Filesystem::mount(
+                $path,
+                $this->config->io(),
+            )
+                ->withCaseSensitivity(
+                    $this->config->filesystemCaseSensitivity(),
+                );
+            $this->mounted[$adapter] = $path->toString();
+
+            return $adapter;
+        });
     }
 
     #[\Override]

src/Filesystem/Logger.php

@@ -38,11 +38,13 @@ public static function psr(
     }
 
     #[\Override]
-    public function mount(Path $path): Adapter
+    public function mount(Path $path): Attempt
     {
-        return Adapter\Logger::psr(
-            $this->filesystem->mount($path),
-            $this->logger,
+        return $this->filesystem->mount($path)->map(
+            fn($adapter) => Adapter\Logger::psr(
+                $adapter,
+                $this->logger,
+            ),
         );
     }
 

tests/FactoryTest.php

@@ -49,7 +49,8 @@ public function testPersistingFileOnCaseInsensitiveFilesystem()
         $os = Factory::build(Config::of()->caseInsensitiveFilesystem());
         $adapter = $os
             ->filesystem()
-            ->mount(Path::of($path));
+            ->mount(Path::of($path))
+            ->unwrap();
         $adapter->add(
             $directory = Directory::named('0')
                 ->add($file = File::named('L', Content::none()))

tests/Filesystem/GenericTest.php

@@ -49,7 +49,7 @@ public function testMount()
             Config::of(),
         );
 
-        $adapter = $filesystem->mount(Path::of('/tmp/'));
+        $adapter = $filesystem->mount(Path::of('/tmp/'))->unwrap();
 
         $this->assertInstanceOf(FilesystemAdapter::class, $adapter);
     }
@@ -61,9 +61,9 @@ public function testMountingTheSamePathTwiceReturnsTheSameAdapter()
             Config::of(),
         );
 
-        $adapter = $filesystem->mount(Path::of('/tmp/'));
+        $adapter = $filesystem->mount(Path::of('/tmp/'))->unwrap();
 
-        $this->assertSame($adapter, $filesystem->mount(Path::of('/tmp/')));
+        $this->assertSame($adapter, $filesystem->mount(Path::of('/tmp/'))->unwrap());
     }
 
     public function testContainsFile()

tests/Filesystem/LoggerTest.php

@@ -14,7 +14,10 @@
     FileWatch\Ping,
 };
 use Innmind\TimeWarp\Halt;
-use Innmind\Immutable\Maybe;
+use Innmind\Immutable\{
+    Attempt,
+    Maybe,
+};
 use Psr\Log\LoggerInterface;
 use PHPUnit\Framework\TestCase;
 use Innmind\BlackBox\{
@@ -47,11 +50,15 @@ public function testMount()
                 $inner
                     ->expects($this->once())
                     ->method('mount')
-                    ->with($path);
+                    ->with($path)
+                    ->willReturn(Attempt::result($this->createMock(Adapter::class)));
                 $logger = $this->createMock(LoggerInterface::class);
                 $filesystem = Logger::psr($inner, $logger);
 
-                $this->assertInstanceOf(Adapter\Logger::class, $filesystem->mount($path));
+                $this->assertInstanceOf(
+                    Adapter\Logger::class,
+                    $filesystem->mount($path)->unwrap(),
+                );
             });
     }