Skip to content

Commit 1af54d5

Browse files
committed
fix
Signed-off-by: kerthcet <kerthcet@gmail.com>
1 parent ecad98b commit 1af54d5

4 files changed

Lines changed: 11 additions & 4 deletions

File tree

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ test-e2e: $(PYTEST) dev
6161
@echo "Cleaning up containers..."
6262
docker compose -f docker-compose.e2e.yml down
6363

64+
docker-build:
65+
docker compose -f docker-compose.e2e.yml build
66+
6467
docker-up:
6568
docker compose -f docker-compose.e2e.yml up -d
6669

examples/interactive_session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def main():
1818
print("Interactive Session Example")
1919
print("=" * 50)
2020

21-
# Connect to server
21+
# Connect to server, disable verbose logging for cleaner output
2222
server = Server("127.0.0.1", 8765, verbose=False)
2323
print(f"✓ Server started on {server.address}\n")
2424

python/sandd/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
"Please build the package with: make install"
3939
) from e
4040

41-
__version__ = "0.0.0"
4241
__all__ = [
4342
"Server",
4443
"Session",

sandd/src/session.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,16 @@ impl SessionManager {
5858
.openpty(pty_size)
5959
.map_err(|e| anyhow!("Failed to open PTY: {}", e))?;
6060

61-
// Spawn session
61+
// Spawn session - try bash first, fall back to $SHELL, then /bin/sh
6262
let session = if cfg!(target_os = "windows") {
6363
"cmd.exe".to_string()
6464
} else {
65-
std::env::var("SHELL").unwrap_or_else(|_| "/bin/sh".to_string())
65+
// Prefer bash (most compatible), then user's shell, then POSIX sh
66+
if std::path::Path::new("/bin/bash").exists() {
67+
"/bin/bash".to_string()
68+
} else {
69+
std::env::var("SHELL").unwrap_or_else(|_| "/bin/sh".to_string())
70+
}
6671
};
6772

6873
let mut cmd = CommandBuilder::new(&session);

0 commit comments

Comments
 (0)