Skip to content

All Offer APIs#24

Draft
petrubraha wants to merge 23 commits into
mainfrom
offers
Draft

All Offer APIs#24
petrubraha wants to merge 23 commits into
mainfrom
offers

Conversation

@petrubraha
Copy link
Copy Markdown
Member

@petrubraha petrubraha commented May 4, 2026 •
edited
Loading

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c57bda1f-21ee-46c0-9bad-ae06bc72aba3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch offers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@petrubraha petrubraha linked an issue May 4, 2026 that may be closed by this pull request
Offer Resource APIs #12
Open
petrubraha added 22 commits May 4, 2026 13:43
@petrubraha petrubraha self-assigned this May 4, 2026
@petrubraha petrubraha added the enhancement New feature or request label May 4, 2026
petrubraha
petrubraha commented May 4, 2026
View reviewed changes
Comment thread model/offer/offer-io.smithy
structure ListOffersInput with [InputPagination] {
@required
@httpLabel
brandSlug: Slug
Copy link
Copy Markdown
Member Author

@petrubraha petrubraha May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dd some queries. offers added today? offer to expire today, tomorrow, in a week? offer to a product? offers in a store?

petrubraha
petrubraha commented May 4, 2026
View reviewed changes
Comment thread model/offer/offer-apis.smithy
input: CreateOfferInput
output: OfferSummary
errors: [
ResourceAlreadyExistsError
Copy link
Copy Markdown
Member Author

@petrubraha petrubraha May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also 404 error, in case that brandSlug does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrubraha petrubraha

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Offer Resource APIs

1 participant

@petrubraha