Skip to content

Commit 0ee95f2

Browse files
committed
minor cleanup
1 parent 7c10109 commit 0ee95f2

File tree

1 file changed

+6
-19
lines changed

1 file changed

+6
-19
lines changed

src/pyff/resource.py

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -5,36 +5,24 @@
55
"""
66
from __future__ import annotations
77

8-
import logging
98
import os
109
import traceback
1110
from collections import deque
1211
from copy import deepcopy
1312
from datetime import datetime
1413
from threading import Condition, Lock
15-
from typing import Deque, Optional, Dict, Mapping, Any, Callable, Tuple
16-
from requests.adapters import Response
14+
from typing import Any, Callable, Deque, Dict, Optional, Tuple
15+
from urllib.parse import quote as urlescape
1716

1817
import requests
18+
from requests.adapters import Response
1919

2020
from .constants import config
2121
from .exceptions import ResourceException
2222
from .fetch import make_fetcher
2323
from .logs import get_log
2424
from .parse import parse_resource
25-
from urllib.parse import quote as urlescape
26-
27-
from .utils import (
28-
Watchable,
29-
hex_digest,
30-
img_to_data,
31-
non_blocking_lock,
32-
url_get,
33-
utc_now,
34-
resource_string,
35-
resource_filename,
36-
safe_write,
37-
)
25+
from .utils import Watchable, hex_digest, img_to_data, non_blocking_lock, resource_string, safe_write, url_get, utc_now
3826

3927
requests.packages.urllib3.disable_warnings()
4028

@@ -244,10 +232,9 @@ def walk(self):
244232
yield cn
245233

246234
def is_expired(self) -> bool:
247-
if self.never_expires:
235+
if self.never_expires or self.expire_time is None:
248236
return False
249-
now = utc_now()
250-
return self.expire_time is not None and self.expire_time < now
237+
return self.expire_time < utc_now()
251238

252239
def is_valid(self) -> bool:
253240
return not self.is_expired() and self.last_seen is not None and self.last_parser is not None

0 commit comments

Comments
 (0)