code cleanup

Author: peppelinux

djangosaml2/backends.py

@@ -24,7 +24,6 @@
 from django.core.exceptions import (ImproperlyConfigured,
                                     MultipleObjectsReturned)
 
-from .signals import pre_user_save
 
 logger = logging.getLogger('djangosaml2')
 

djangosaml2/middleware.py

@@ -1,5 +1,4 @@
 import time
-from importlib import import_module
 
 from django.conf import settings
 from django.contrib.sessions.backends.base import UpdateError

djangosaml2/tests/__init__.py

@@ -25,7 +25,6 @@
 from django.contrib.auth import SESSION_KEY, get_user_model
 from django.contrib.auth.models import AnonymousUser
 from django.core.exceptions import ImproperlyConfigured
-from django.template import Context, Template
 from django.test import Client, TestCase, override_settings
 from django.test.client import RequestFactory
 from django.urls import reverse
@@ -39,8 +38,7 @@
                                get_session_id_from_saml2,
                                get_subject_id_from_saml2,
                                saml2_from_httpredirect_request)
-from djangosaml2.views import (EchoAttributesView, _set_subject_id,
-                               finish_logout)
+from djangosaml2.views import (EchoAttributesView, finish_logout)
 from saml2.config import SPConfig
 from saml2.s_utils import decode_base64_and_inflate, deflate_and_base64_encode
 

djangosaml2/utils.py

@@ -20,7 +20,6 @@
 from django.conf import settings
 from django.core.exceptions import ImproperlyConfigured
 from django.utils.http import is_safe_url
-from django.utils.module_loading import import_string
 from saml2.config import SPConfig
 from saml2.s_utils import UnknownSystemEntity
 

djangosaml2/views.py

@@ -402,7 +402,6 @@ def post(self, request, attribute_mapping=None, create_unknown_user=None):
     def post_login_hook(self, request: HttpRequest, user: settings.AUTH_USER_MODEL, session_info: dict) -> None:
         """ If desired, a hook to add logic after a user has succesfully logged in.
         """
-        pass
 
     def build_relay_state(self) -> str:
         """ The relay state is a URL used to redirect the user to the view where they came from.
@@ -418,7 +417,6 @@ def build_relay_state(self) -> str:
     def customize_session(self, user, session_info: dict):
         """ Subclasses can use this for customized functionality around user sessions.
         """
-        pass
 
     def customize_relay_state(self, relay_state: str) -> str:
         """ Subclasses may override this method to implement custom logic for relay state.

tests/settings.py

@@ -12,7 +12,6 @@
 
 import os
 
-import django
 
 # Build paths inside the project like this: os.path.join(BASE_DIR, ...)
 BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))