fixed echo_Attributes template and null lenght of saml_attributes

Author: peppelinux

djangosaml2/backends.py

@@ -94,12 +94,12 @@ def _get_attribute_value(self, django_field: str, attributes: dict, attribute_ma
         logger.debug('attribute_mapping: %s', attribute_mapping)
         for saml_attr, django_fields in attribute_mapping.items():
             if django_field in django_fields and saml_attr in attributes:
-                saml_attribute = attributes.get(saml_attr, [None])[0]
-                if not saml_attribute:
+                saml_attribute = attributes.get(saml_attr, [None])
+                if not saml_attribute or not saml_attribute[0]:
                     logger.error('attributes[saml_attr] attribute '
                                  'value is missing. Probably the user '
                                  'session is expired.')
-        return saml_attribute
+        return saml_attribute[0]
 
     def authenticate(self, request, session_info=None, attribute_mapping=None, create_unknown_user=True, **kwargs):
         if session_info is None or attribute_mapping is None:

djangosaml2/views.py

@@ -124,8 +124,7 @@ def get_next_path(self, request: HttpRequest) -> str:
         return next_path
 
     def get(self, request, *args, **kwargs):
-        logger.debug('Login process started')
-
+        logger.debug('Login process started')        
         next_path = self.get_next_path(request)
 
         # if the user is already authenticated that maybe because of two reasons:
@@ -320,7 +319,7 @@ def post(self, request, attribute_mapping=None, create_unknown_user=None):
         oq_cache = OutstandingQueriesCache(request.saml_session)
         oq_cache.sync()
         outstanding_queries = oq_cache.outstanding_queries()
-
+        
         _exception = None
         try:
             response = client.parse_authn_request_response(request.POST['SAMLResponse'],
@@ -373,7 +372,7 @@ def post(self, request, attribute_mapping=None, create_unknown_user=None):
             attribute_mapping = attribute_mapping()
         if callable(create_unknown_user):
             create_unknown_user = create_unknown_user()
-
+        
         logger.debug('Trying to authenticate the user. Session info: %s', session_info)
         user = auth.authenticate(request=request,
                                  session_info=session_info,