Support PHP 8.5 (#61)

PHP 8.4:
- Function parameters that are null by default must be declared nullable
- PriorityQueue: Ensure compatibility of return type with SplPriorityQueue

Other changes:
- Fix programming error causing undefined property access when dynamic
value is unset
- PHPStan `scanDirectories` was adjusted so that tests are always run
with the dependencies installed by `composer install`

No changes are required to support PHP 8.5.

Author: lippserd

phpstan.neon

@@ -11,9 +11,6 @@ parameters:
     paths:
         - src
 
-    scanDirectories:
-        - /usr/share/icinga-php
-
     ignoreErrors:
         -
             messages:

src/BaseFilter.php

@@ -32,11 +32,11 @@ public function getBaseFilter()
     /**
      * Set the base filter
      *
-     * @param Rule $baseFilter
+     * @param ?Rule $baseFilter
      *
      * @return $this
      */
-    public function setBaseFilter(Rule $baseFilter = null): self
+    public function setBaseFilter(?Rule $baseFilter = null): self
     {
         $this->baseFilter = $baseFilter;
 

src/Filter.php

@@ -536,11 +536,7 @@ protected function performMatch(Rule $rule, $row)
      */
     protected function extractValue($column, $row)
     {
-        try {
-            return $row->{$column};
-        } catch (Throwable $_) {
-            return null;
-        }
+        return $row->$column ?? null;
     }
 
     /**

src/PriorityQueue.php

@@ -25,9 +25,9 @@ class PriorityQueue extends SplPriorityQueue
      * @param TValue $value
      * @param TPriority $priority
      *
-     * @return bool
+     * @return true
      */
-    public function insert($value, $priority): bool
+    public function insert($value, $priority): true
     {
         return parent::insert($value, [$priority, $this->serial--]);
     }

src/Str.php

@@ -76,7 +76,7 @@ public static function symmetricSplit(?string $subject, string $delimiter, int $
      *
      * @return array<string>
      */
-    public static function trimSplit(?string $subject, string $delimiter = ',', int $limit = null)
+    public static function trimSplit(?string $subject, string $delimiter = ',', ?int $limit = null)
     {
         if ($subject === null || empty($delimiter)) {
             return [];